Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Improve the comment closing override text #3102

Closed
quicksketch opened this issue May 10, 2018 · 4 comments
Closed

[UX] Improve the comment closing override text #3102

quicksketch opened this issue May 10, 2018 · 4 comments

Comments

@quicksketch
Copy link
Member

quicksketch commented May 10, 2018

Describe your issue or idea

Follow-up to #3001 where we added comment closing capability. We should improve the UX of the "Override the automatic closing of comments" checkbox:

image

The wording and functionality here is awkward. Checking the box disables the automatic closing. Whereas on the content type form, you check the box to enable automatic closing. Instead what should be done here is the checkbox should by checked all the time by default if automatic closing is enabled, and you would uncheck the box to disable the automatic closing. Such as this:

image

Relevant version/system information (if applicable)

Backdrop 1.x (1.10 dev)

@quicksketch
Copy link
Member Author

PR filed at backdrop/backdrop#2183.

@herbdool
Copy link

The change looks reasonable and code looks good!

@herbdool
Copy link

I've also tested it out too. Works as expected and the UX is more sensible.

@quicksketch
Copy link
Member Author

Thanks @herbdool! Merged backdrop/backdrop#2183 into 1.x for 1.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants