[UX] Contact form categories: better messages

[klonos]

Part of the #3023 META...

1. When the "Recipients" text area contains more than one invalid email addresses, the validation message only tells the user about the first one that is not valid:

   

   I think we should either be listing all invalid addresses, or in the case where more than one, have the message be generic, like "Multiple invalid email addresses detected." or something.

2. The success message is "Category xyz has been saved/deleted.". I think that it should be "Contact form category xyz has been saved." instead.

   

   ...especially for the watchdog message:

   

---

PR backdrop/backdrop#2257

[opi]

Creating PR backdrop/backdrop#2257 as a starter for discussion.

1. Here are the 2 error messages, depending if there is one or more invalid addresses:

   • test@wrong is an invalid e-mail address.
   • test@wrong, more, error are invalid e-mail addresses.

2. Totally agree

[klonos]

...the way this is currently implemented in the PR, we check whether there is one or multiple invalid email addresses. If we wanted to achieve "natural language", we should be having the message including an "and" between the previous to last and the last item. Something like this: https://stackoverflow.com/questions/8586141/implode-array-with-and-add-and-before-last-item

...but this complicates things even more code-wise. I think that it'd be better, and more readable if we said something like "The following are not valid email addresses:" ...and then we had the invalid ones in a list.

[opi]

Poll:

1. "The following are not valid email addresses: aaa, bbb, ccc"
2. "The following email addresses are not valid: aaa, bbb, ccc"

[klonos]

Either is fine by me.

[opi]

PR updated with this message: The following email addresses are not valid: %recipients..

[klonos]

Looks good to me, and you can ignore my next comment and consider this RTBC, but I get annoyed by the fact that we use "not valid" for multiple and "invalid" for one:

The following email addresses are not valid: ...
xyz is an invalid e-mail address.

Either change the first to The following email addresses are invalid: ..., or change the second to xyz is not a valid e-mail address..

I don't have a preference, either one is fine ...it's the inconsistency that bothers me. Sorry ...OCD 😄

[opi]

PR updated with The following email addresses are invalid: %recipients.. Mostly because '%recipient is an invalid e-mail address.' should be already translated in most cases.

[klonos]

Yep, RTBC 😉

[opi]

PR rebase against 1.x, and updated with a proper format_plural usage. Back to "need review" then.

[opi]

@serundeputy is this long line OK with coding standards ?

[herbdool]

Tested and looks good to me.

@opi that line doesn't look any longer than others nearby.

[quicksketch]

To avoid unnecessary string changes in 1.10.x, I've merged backdrop/backdrop#2257 into 1.x only.

Thanks everyone!