-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Contact form categories: better messages #3215
Comments
Creating PR backdrop/backdrop#2257 as a starter for discussion.
|
...the way this is currently implemented in the PR, we check whether there is one or multiple invalid email addresses. If we wanted to achieve "natural language", we should be having the message including an "and" between the previous to last and the last item. Something like this: https://stackoverflow.com/questions/8586141/implode-array-with-and-add-and-before-last-item ...but this complicates things even more code-wise. I think that it'd be better, and more readable if we said something like "The following are not valid email addresses:" ...and then we had the invalid ones in a list. |
Poll:
|
Either is fine by me. |
PR updated with this message: |
Looks good to me, and you can ignore my next comment and consider this RTBC, but I get annoyed by the fact that we use "not valid" for multiple and "invalid" for one:
Either change the first to I don't have a preference, either one is fine ...it's the inconsistency that bothers me. Sorry ...OCD 😄 |
PR updated with |
Yep, RTBC 😉 |
PR rebase against 1.x, and updated with a proper format_plural usage. Back to "need review" then. |
@serundeputy is this long line OK with coding standards ? |
Tested and looks good to me. @opi that line doesn't look any longer than others nearby. |
To avoid unnecessary string changes in 1.10.x, I've merged backdrop/backdrop#2257 into 1.x only. Thanks everyone! |
Part of the #3023 META...
When the "Recipients" text area contains more than one invalid email addresses, the validation message only tells the user about the first one that is not valid:
I think we should either be listing all invalid addresses, or in the case where more than one, have the message be generic, like "Multiple invalid email addresses detected." or something.
The success message is "Category
xyz
has been saved/deleted.". I think that it should be "Contact form categoryxyz
has been saved." instead....especially for the watchdog message:
PR backdrop/backdrop#2257
The text was updated successfully, but these errors were encountered: