-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Show CKEditor in the site status report page. #3360
Comments
...OK, PR up for review:
|
We should check, if module "CKEditor" enabled before reporting. |
You are absolutely right @findlabnet 👍 ...I was under the impression that ckeditor.module was a system module, hence required and always on by default. This explains those PR updated. |
This doesn't look like a feature request, just a UX issue. Adjusting tags and milestones. |
...I have split the jQuery changes off to a separate issue: #3879. Hoping to make it easier to review and approve this change here. |
I've reviewed the previous PR as well as one I created today, and I went with the newer one. The older one changed a lot of things not related to the task and those changes were what caused most of the change requests on the PR. One major difference between the newer one and the older, was that the older one depended on the constant I'm not sure if the constant Perhaps the runtime check will help? I would much prefer to use |
I left some suggestions on the PR. |
Suggestions merged. |
By @jenlampton, @klonos, @kiamlaluno, @quicksketch, @docwilmot, @BWPanda, @stpaultim, and @jromine.
By @jenlampton, @klonos, @kiamlaluno, @quicksketch, @docwilmot, @BWPanda, @stpaultim, and @jromine.
I merged backdrop/backdrop#4509 into 1.x and 1.25.x (just in case that gets any installs) to start including CKEditor version in the status report. Thanks everyone for their feedback, review, and code! backdrop/backdrop@d657bfa by @jenlampton, @klonos, @kiamlaluno, @quicksketch, @docwilmot, @BWPanda, @stpaultim, and @jromine. |
PR by @klonos: backdrop/backdrop#2348
The text was updated successfully, but these errors were encountered: