Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that disabling a theme also resets its settings #3533

Closed
klonos opened this issue Feb 8, 2019 · 4 comments
Closed

Indicate that disabling a theme also resets its settings #3533

klonos opened this issue Feb 8, 2019 · 4 comments

Comments

@klonos
Copy link
Member

klonos commented Feb 8, 2019

Follow-up to #3478

@quicksketch:

Seems like we can merge this as-is, but we need a follow-up to indicate that disabling a theme also resets its settings.

@docwilmot:

This PR makes disabling a theme a destructive process now. For a complex theme that would lose all configuration, this may be unexpected. Should we add a confirm form to theme settings form?

Here it is 😉


PR backdrop/backdrop#2507

@herbdool
Copy link

I created a PR backdrop/backdrop#2507. I took @docwilmot's approach of adding a confirmation form when disabling a theme.

@klonos
Copy link
Member Author

klonos commented Mar 23, 2019

Thanks @herbdool 👍 ...PR looks good. I have left some comments.

@klonos
Copy link
Member Author

klonos commented Mar 24, 2019

This is RTBC ...I will file a separate issue about the things mentioned in the PR comments.

@klonos klonos added this to the 1.12.6 milestone Mar 24, 2019
@quicksketch
Copy link
Member

Looks good! Merged backdrop/backdrop#2507 into 1.x and 1.12.x. Thanks @herbdool and @klonos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants