Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the translation links in the installer from drupal.org to backdropcms.org #3560

Closed
3 tasks done
jenlampton opened this issue Feb 28, 2019 · 17 comments · Fixed by backdrop/backdrop#2571
Closed
3 tasks done

Comments

@jenlampton
Copy link
Member

jenlampton commented Feb 28, 2019


PR by @olafgrabienski: backdrop/backdrop#2571

@olafgrabienski
Copy link

olafgrabienski commented Mar 1, 2019

Reminder: identify all the links to localize.drupal.org. I'm not sure if there are only links in the installer or also somewhere in the language related pages of the user interface.

Update: I've checked the code base for the string localize.drupal.org. Apart from install.core.inc, I found it only in code comments. So, the only link to localize.drupal.org in the user interface is the one in the installer.

@jenlampton jenlampton modified the milestones: 1.12.4, 1.12.5 Mar 13, 2019
@klonos klonos modified the milestones: 1.12.5, 1.12.6 Mar 20, 2019
@olafgrabienski
Copy link

There are two drupal.org related lines in core/includes/install.core.inc:

Download link, l. 1355:
$output .= '<li>Download a translation from the <a href="http://localize.drupal.org/download" target="_blank">translation server</a>.</li>';

Documentation link, l. 1358:
$output .= '<p>For more information on installing Backdrop in different languages, visit the <a href="http://drupal.org/localize" target="_blank">drupal.org handbook page</a>.</p>';

I'm going to update the title and issue description to include also the documentation part.

@olafgrabienski olafgrabienski changed the title Switch the translation link from localize.drupal.org to localize.backdropcms.org Switch the translation links from drupal.org to backdropcms.org Apr 5, 2019
@olafgrabienski olafgrabienski changed the title Switch the translation links from drupal.org to backdropcms.org Switch the translation links in the installer from drupal.org to backdropcms.org Apr 5, 2019
olafgrabienski added a commit to olafgrabienski/backdrop that referenced this issue Apr 8, 2019
@olafgrabienski
Copy link

I've made a PR, backdrop/backdrop#2571. It's a two-liner, I hope there's no typo and the wording is fine!

@olafgrabienski olafgrabienski self-assigned this Apr 8, 2019
@klonos
Copy link
Member

klonos commented Apr 9, 2019

The PR looks fine @olafgrabienski 👍 ...thanks.

The actual b.org pages may need some work to bring them in parity with the respective d.org ones though.

@olafgrabienski
Copy link

olafgrabienski commented Apr 9, 2019

Thanks for the review, @klonos!

The actual b.org pages may need some work to bring them in parity with the respective d.org ones though.

Yes, the documentation pages need for sure some work. Regarding installing Backdrop in other languages there is backdrop-ops/backdropcms.org#523. (In my opinion, also the main page about installing Backdrop could be improved -- primarily arranged more clearly --, but that's stuff for a separate issue some day.)

@quicksketch
Copy link
Member

This looks great! Those last few drupal.org links are fairly embarrassing at this point, especially as one of them is on the very first page of the installer.

I don't see any actual page at https://backdropcms.org/user-guide/install-backdrop-another-language though. And I didn't see a page for installing Backdrop anywhere in the user guide actually, seems it's actually under "Developer Notes" these days? https://backdropcms.org/installation

IMO we should ensure the URL never changes, so perhaps removing /user-guide from the portion of the URL would be smart to future-proof it.

@olafgrabienski
Copy link

I don't see any actual page at https://backdropcms.org/user-guide/install-backdrop-another-language though.

Are you sure? I see it.

And I didn't see a page for installing Backdrop anywhere in the user guide actually, seems it's actually under "Developer Notes" these days? https://backdropcms.org/installation

Yes, that's correct, it's part of the Developer Notes, so removing the /user-guide part of the URL -- or replace it by /installation -- is a good idea.

(It's however strange not to have information about installing Backdrop in the User Guide.)

we should ensure the URL never changes

Hoping there are automatic redirects.

@olafgrabienski
Copy link

olafgrabienski commented Apr 9, 2019

@quicksketch As the documentation page isn't part of the PR (but discussed in issue backdrop-ops/backdropcms.org#523), I'm not sure why to remove the pr works ... label. What the PR does (changing the documentation link and the translation server link), is still working, so it actually doesn't need work, in my opinion.

I agree that it needs documentation ... or clarification at which URL the documentation should live, as discussed above.

@olafgrabienski
Copy link

What the PR does (changing the documentation link and the translation server link), is still working, so it actually doesn't need work, in my opinion.

Oh, sorry, got it: I have to change the documentation link in the PR when we have a new URL!

@klonos
Copy link
Member

klonos commented Apr 10, 2019

I don't see any actual page at backdropcms.org/user-guide/install-backdrop-another-language though.

Are you sure? I see it.

Yep, I see it too. I have checked all the b.org links in the PR.

@klonos
Copy link
Member

klonos commented Apr 10, 2019

...I personally don't mind the /user-guide in the URL. I know that for some "popular" documentation pages we have removed it, but so long as these pages live in the user guide, and since URL redirects work, we can have both in place. Let's use the shorter version in the PR though 😉

@olafgrabienski
Copy link

@klonos Thanks for your feedback! I'll change the URL in the PR to use the shorter version when the URL of the documentation page is changed, cf. backdrop-ops/backdropcms.org#523 (comment).

@jenlampton
Copy link
Member Author

I've updated the URL of the other page to https://backdropcms.org/installing-in-other-languages. Does that work?

@olafgrabienski
Copy link

I've updated the URL of the other page to https://backdropcms.org/installing-in-other-languages.

Thanks! I've also updated the documentation URL in the PR. @klonos Can you have another look at it?

@klonos
Copy link
Member

klonos commented Apr 15, 2019

PR still looks good 👍 ...lets get rid of as many remaining d.org links in the codebase as possible; we can improve on the actual documentation pages on b.org iteratively.

@olafgrabienski
Copy link

To merge this PR, it makes sense to also have #3674 in the same release. The PR over there allows to use .po translation files from b.org in the installer without having to rename them before.

@quicksketch
Copy link
Member

Looks great! I posted some feedback on #3674, but this one is good to go. Nice new handbook page and thank you for making a "permanent" URL that isn't dependent on the structure backdropcms.org. Merged backdrop/backdrop#2571 into 1.x and 1.12.x. Thanks @olafgrabienski, @jenlampton, and @klonos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment