Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'Code of Conduct' section to README.md #3632

Closed
jenlampton opened this issue Mar 28, 2019 · 38 comments · Fixed by backdrop/backdrop#3114
Closed

Add a 'Code of Conduct' section to README.md #3632

jenlampton opened this issue Mar 28, 2019 · 38 comments · Fixed by backdrop/backdrop#3114

Comments

@jenlampton
Copy link
Member

jenlampton commented Mar 28, 2019

We should put a copy of our code of conduct into the core repository. The text is located here: https://github.com/backdrop-ops/conduct/blob/master/code_of_conduct.md

Instructions on how to add a code of conduct can be found here:
https://help.github.com/en/articles/adding-a-code-of-conduct-to-your-project


COC PR: backdrop-ops/conduct#4 merged
Core PR: backdrop/backdrop#2840
PR: backdrop/backdrop#3114

@klonos
Copy link
Member

klonos commented Apr 2, 2019

@jenlampton I have formatted the file to 80 chars line limit. Please review and merge: backdrop-ops/conduct#4 ...we can then add the document to core.

@klonos
Copy link
Member

klonos commented Apr 2, 2019

...since this is not actually touching any code, I believe it can be added anytime. So proposing version 1.12.6 as a milestone.

@jenlampton jenlampton added this to the 1.12.6 milestone Apr 3, 2019
@jenlampton jenlampton modified the milestones: 1.12.6, 1.12.7 Apr 17, 2019
@jenlampton jenlampton modified the milestones: 1.12.7, 1.13.1 May 15, 2019
@jenlampton jenlampton modified the milestones: 1.13.1, 1.13.2 May 23, 2019
@klonos klonos modified the milestones: 1.13.2, 1.13.3 Jun 1, 2019
@quicksketch quicksketch modified the milestones: 1.13.3, 1.13.4 Aug 7, 2019
@ghost
Copy link

ghost commented Sep 2, 2019

Copied the file into core. PR here: backdrop/backdrop#2840

@klonos
Copy link
Member

klonos commented Sep 2, 2019

Thanks @BWPanda 👍

@quicksketch
Copy link
Member

I'd like to hold on this until we can remove files from the packaged (download) version of Backdrop. Files that are meant for GitHub integration shouldn't end up in the packaged version.

@jenlampton jenlampton modified the milestones: 1.13.4, 1.15.0 Sep 16, 2019
@jenlampton
Copy link
Member Author

PR looks great to me. RTBC :)

@stpaultim
Copy link
Member

Looks good. To be clear, the current PR includes a short statement in the README file about the code of conduct with a link to https://github.com/backdrop-ops/conduct/blob/master/code_of_conduct.md

This looks good to me. I am glad to see this moving forward.

@ghost
Copy link

ghost commented Mar 29, 2021

Yep:

image

@quicksketch
Copy link
Member

Current PR looks good to me too.

@quicksketch
Copy link
Member

Oops, sorry there is an issue with the link referencing the old name of the branch (master instead of main): https://github.com/backdrop/backdrop/pull/3114/files#r603015680

@ghost
Copy link

ghost commented Mar 29, 2021

PR updated.

@jenlampton
Copy link
Member Author

Nice catch! Sorry, I changed that earlier today :/

@ghost ghost changed the title Add a CODE_OF_CONDUCT.md to core Add a 'Code of Conduct' section to README.md Mar 29, 2021
@quicksketch
Copy link
Member

As this is escalated to the PMC as of yesterday (#3632 (comment)), I want to hold off on merging this until a decision is made there.

IMO the PR at backdrop/backdrop#3114 looks good and no downsides. We could take it further by putting directly in the core repo. However, benefit there is only minimal since right now all of our issues are here, in the backdrop-issues queue, so we won't get GitHub's automatic integration by putting it in the backdrop repository. As a core committer, I would prefer that policy documents are manageable by the PMC separately from the rest of core. I agree with @herbdool's comment that we should make it easy to find. I think the README.md is a good start.

@jackaponte
Copy link

The PMC yesterday voted unanimously in favor of adding this CoC link to the README.md. Thank you for this work y'all!

@ghost
Copy link

ghost commented Mar 31, 2021

Can we merge the PR then, or are we waiting on anything else...?

@quicksketch
Copy link
Member

Yep, we're set! @BWPanda if you get the chance before I do, please merge into 1.x and 1.18.x.

@ghost
Copy link

ghost commented Mar 31, 2021

Thanks everyone for your feedback, especially to @quicksketch, @jenlampton, @klonos & @stpaultim for your help with reviewing the PR. I've merged backdrop/backdrop#3114 into 1.x and 1.18.x.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants