-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 'Code of Conduct' section to README.md #3632
Comments
@jenlampton I have formatted the file to 80 chars line limit. Please review and merge: backdrop-ops/conduct#4 ...we can then add the document to core. |
...since this is not actually touching any code, I believe it can be added anytime. So proposing version 1.12.6 as a milestone. |
Copied the file into core. PR here: backdrop/backdrop#2840 |
Thanks @BWPanda 👍 |
I'd like to hold on this until we can remove files from the packaged (download) version of Backdrop. Files that are meant for GitHub integration shouldn't end up in the packaged version. |
PR looks great to me. RTBC :) |
Looks good. To be clear, the current PR includes a short statement in the README file about the code of conduct with a link to https://github.com/backdrop-ops/conduct/blob/master/code_of_conduct.md This looks good to me. I am glad to see this moving forward. |
Current PR looks good to me too. |
Oops, sorry there is an issue with the link referencing the old name of the branch ( |
PR updated. |
Nice catch! Sorry, I changed that earlier today :/ |
As this is escalated to the PMC as of yesterday (#3632 (comment)), I want to hold off on merging this until a decision is made there. IMO the PR at backdrop/backdrop#3114 looks good and no downsides. We could take it further by putting directly in the core repo. However, benefit there is only minimal since right now all of our issues are here, in the |
The PMC yesterday voted unanimously in favor of adding this CoC link to the README.md. Thank you for this work y'all! |
Can we merge the PR then, or are we waiting on anything else...? |
Yep, we're set! @BWPanda if you get the chance before I do, please merge into 1.x and 1.18.x. |
Thanks everyone for your feedback, especially to @quicksketch, @jenlampton, @klonos & @stpaultim for your help with reviewing the PR. I've merged backdrop/backdrop#3114 into 1.x and 1.18.x. |
We should put a copy of our code of conduct into the core repository. The text is located here: https://github.com/backdrop-ops/conduct/blob/master/code_of_conduct.md
Instructions on how to add a code of conduct can be found here:
https://help.github.com/en/articles/adding-a-code-of-conduct-to-your-project
COC PR: backdrop-ops/conduct#4mergedCore PR: backdrop/backdrop#2840PR: backdrop/backdrop#3114
The text was updated successfully, but these errors were encountered: