There is no way to clean out old test run database tables

[jenlampton]

Description of the bug
After a test fails half-way through, you get directed to the "error page". On the "error page" you will see a message that says;

Use the Clean environment button to clean-up temporary files and tables. 

But there is no "Clean environment button" provided on the error page.

Steps To Reproduce
To reproduce the behavior:

1. Run a test that fatals out half way through
2. Click on 'error page'
3. Notice the orange warning
4. Look for the mysterious button

[herbdool]

The button should be way at the bottom. Isn't it?

[jenlampton]

Not always

…

On Tue, Jun 25, 2019, 7:35 AM Herb ***@***.***> wrote: The button should be way at the bottom. Isn't it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3868?email_source=notifications&email_token=AADBER6CJ7TZPNV4PQK34C3P4IULJA5CNFSM4HYOIXU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYQOUBQ#issuecomment-505473542>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBER433FG43RWWD6NBEKLP4IULJANCNFSM4HYOIXUQ> .

[klonos]

So the problem seems to be that this button is located at the bottom of the "List tests" page (admin/config/development/testing) - not in the "Test results" page.

We have 3 options:

1. link to that page from the warning, and scroll to the bottom, where the "Clean test environment" fieldset is located
2. duplicate the "Clean test environment" fieldset in the test results page.
3. move the "Clean test environment" fieldset to the test results page.

Which one do we want?

[klonos]

...another point is that we have a "Clear results after each complete test suite run" checkbox in admin/config/development/testing/settings, which is on by default OOTB:

By default SimpleTest will clear the results after they have been viewed on the results page, but in some cases it may be useful to leave the results in the database. The results can then be viewed at admin/config/development/testing/[test_id]. The test ID can be found in the database, simpletest table, or kept track of when viewing the results the first time. Additionally, some modules may provide more analysis or features that require this setting to be disabled.

Which if I am reading things correctly, means that the "Clean test environment" fieldset should not be available when that setting is on. Right?

[jenlampton]

So the problem seems to be that this button is located at the bottom of the "List tests" page (admin/config/development/testing) - not in the "Test results" page.

Sometimes it does on the test results page (your option 2), but it wasn't in this instance. Maybe we could solve the problem by always adding a link into the message (your option 1) Then we could remove it from this page always (for consistency) and take the mystery out of it.

Or, we could do option 3.

the "Clean test environment" fieldset should not be available when that setting is on. Right?

Well, in my case the tests failed half way through. I needed the button regardless of the setting.