Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Make user_save() more backwards-compatible #3921

Open
klonos opened this issue Jul 10, 2019 · 1 comment
Open

[DX] Make user_save() more backwards-compatible #3921

klonos opened this issue Jul 10, 2019 · 1 comment

Comments

@klonos
Copy link
Member

klonos commented Jul 10, 2019

The signature of the user_save() function has changed in Backdrop:

D7

function user_save($account, $edit = array(), $category = 'account') {
  ...
}

Backdrop:

function user_save($account) {
  return $account->save();
}

I think that we should:

@klonos
Copy link
Member Author

klonos commented Jul 10, 2019

I have put together a PR, which is WIP: backdrop/backdrop#2787

The idea is to have most of the docblock changes ready for review/feedback. I think that we need some sort of an equivalent of watchdog_deprecated_function() for deprecated function parameters. Something like watchdog_deprecated_function_argument() ...but that'd be a separate issue.

@klonos klonos changed the title Make user_save() more backwards-compatible [DX] Make user_save() more backwards-compatible Jul 10, 2019
@klonos klonos closed this as completed Jul 10, 2019
@klonos klonos reopened this Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant