Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] move contents of "Manage file display" page #4031

Open
jenlampton opened this issue Sep 12, 2019 · 5 comments
Open

[UX] move contents of "Manage file display" page #4031

jenlampton opened this issue Sep 12, 2019 · 5 comments

Comments

@jenlampton
Copy link
Member

jenlampton commented Sep 12, 2019

This is a follow-up to #2632

The goal is to get rid of the "Manage file display" page entirely. We should move the settings that are currently on that page under a "configure" link on the File row on the usual "manage displays" page. A good example of what this would look like can be found on any other fieldable entity.

Example of configure link (closed):
link-closed

Example of configure link (open):
link-open

Current settings on the "Manage file display" page:
current

Destination for these settings:
destination


Advocate: @jenlampton


Weekly update?


PR: ?

@jenlampton
Copy link
Member Author

This is going to be particularly difficult because the "file" row on the manage displays page is not a real field, it's a psuedofield, and psuedofields aren't currently allowed to have settings.

I have two ideas for how to approach this:

  1. Allow settings for psuedofields. I think this is the "better" approach because this is a feature contrib may want to use also.
  2. Create a real field for "File" instead of the psuedofield.

If the #1 approach looks too difficult or ends up being too much change, I'll see if #2 is feasible instead.

@jenlampton jenlampton self-assigned this Sep 12, 2019
@docwilmot
Copy link
Contributor

A quick alternative that still removes the ugly, would be instead of a configure button there:

Put a link to this form instead

and remove the menu item for the "Manage File Display" tab.

@jenlampton jenlampton added this to the 1.14.0 milestone Sep 15, 2019
@quicksketch quicksketch removed this from the 1.14.0 milestone Sep 16, 2019
@quicksketch
Copy link
Member

I'm not sure this is possible without an API change. But I think this would/should be a priority item for 1.15.0

@jenlampton
Copy link
Member Author

@docwilmot I looked into adding a link, but psuedofields only allow two things currently: a label and a description. We need to rework them either way, so I'll start by adding a settings form.

@jenlampton
Copy link
Member Author

No updates since Sept 19, clearing milestone. Also unassigning. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants