Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in select.inc. #4261

Closed
docwilmot opened this issue Jan 7, 2020 · 8 comments · Fixed by backdrop/backdrop#3112
Closed

Typo in select.inc. #4261

docwilmot opened this issue Jan 7, 2020 · 8 comments · Fixed by backdrop/backdrop#3112

Comments

@docwilmot
Copy link
Contributor

docwilmot commented Jan 7, 2020

Description of the bug
The code comment on line 1449:

  /**
   * Implements SelectQueryInterface::addField().di
   */
  public function addField($table_alias, $field, $alias = NULL) {

Note the stray "di"


PR: ?

@jenlampton
Copy link
Member

no PR here. removing milestone.

@jenlampton jenlampton removed this from the 1.14.3 milestone Jan 15, 2020
@ps23Rick
Copy link

ps23Rick commented Apr 6, 2020

Hi @jenlampton at-al. I'm looking to tackle some easy low hanging fruit as it were.. This sounds like a good start -- is this ok to open a PR on? I just tackled a task for the headless module elsewhere here on GitHub. Just thought I'd check.. thx

@jenlampton
Copy link
Member

is this ok to open a PR on?

Yep! Go ahead, and thanks!

@ps23Rick
Copy link

ps23Rick commented Apr 7, 2020

Ok.. The PR is open on this one.. One of the CI tests failed but in looking at the log I think its some sort of non-code issue? Perhaps someone with more background than I do on this CI engine can figure that part out..? Thx!

@jenlampton
Copy link
Member

One of the CI tests failed...

Yes, we get random test failures from time to time, we are working to identify and fix them as they crop up!

The PR is open on this one.

I don't see a link to your PR, would you please add one? (Also: if you put the text 'Fixes [link]` in the PR description GitHub will add the link automatically into the sidebar on this issue)

You are also welcome to edit the top post in any issue and add a link to the PR so that others can find it later w/o needing to scroll through all the comments. We've been doing that on most core issues (since before GitHub added the sidebar list of PRs)

@ps23Rick
Copy link

ps23Rick commented Apr 7, 2020

ok.. I'm slowly getting used to GitHub.. I've got 30 years of dev experience but have always used proprietary CM tools.. Slowly but surely.. lol

thanks for the help & direction btw..

@jenlampton
Copy link
Member

This looks great! RTBC :)

@ghost
Copy link

ghost commented Apr 14, 2020

Merged backdrop/backdrop#3112 into 1.x and 1.15.x. Big thanks to @ps23Rick for the PR and to @docwilmot and @jenlampton for finding/reviewing!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants