-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in select.inc. #4261
Comments
no PR here. removing milestone. |
Hi @jenlampton at-al. I'm looking to tackle some easy low hanging fruit as it were.. This sounds like a good start -- is this ok to open a PR on? I just tackled a task for the headless module elsewhere here on GitHub. Just thought I'd check.. thx |
Yep! Go ahead, and thanks! |
Ok.. The PR is open on this one.. One of the CI tests failed but in looking at the log I think its some sort of non-code issue? Perhaps someone with more background than I do on this CI engine can figure that part out..? Thx! |
Yes, we get random test failures from time to time, we are working to identify and fix them as they crop up!
I don't see a link to your PR, would you please add one? (Also: if you put the text 'Fixes [link]` in the PR description GitHub will add the link automatically into the sidebar on this issue) You are also welcome to edit the top post in any issue and add a link to the PR so that others can find it later w/o needing to scroll through all the comments. We've been doing that on most core issues (since before GitHub added the sidebar list of PRs) |
ok.. I'm slowly getting used to GitHub.. I've got 30 years of dev experience but have always used proprietary CM tools.. Slowly but surely.. lol thanks for the help & direction btw.. |
This looks great! RTBC :) |
Merged backdrop/backdrop#3112 into 1.x and 1.15.x. Big thanks to @ps23Rick for the PR and to @docwilmot and @jenlampton for finding/reviewing! |
Description of the bug
The code comment on line 1449:
Note the stray "di"
PR: ?
The text was updated successfully, but these errors were encountered: