Optimize path_admin_form(): Avoid calling url() multiple times.

[klonos]

This came up while reviewing backdrop/backdrop#3522

See backdrop/backdrop#3522 (comment)

Here, we could do something like:

  $field_prefix = url(NULL, array('absolute' => TRUE)) . ($site_config->get('clean_url') ? '' : '?q=');

...and then reuse:

  '#field_prefix' => $field_prefix,

It would save us 2 calls to url() 😉 ...but perhaps scope creep for this PR.

[klonos]

PR: backdrop/backdrop#3533

[indigoxela]

@klonos your PR totally makes sense, but as the same lines already change in the related PR, you'll run into a conflict.

I suppose, one of these PRs has to wait for the other one to get merged.

[klonos]

I suppose, one of these PRs has to wait for the other one to get merged.

Yup. I only created this PR because as small a change as this may be, it still was "scope creep" for the other issue/PR. Happy to wait 🙂

[indigoxela]

As expected - the other issue got merged, so this one now has conflicts. The PR needs a tiny update.

[ghost]

I've fixed the merge conflicts in the PR. Ready for review/testing.

[indigoxela]

@BWPanda many thanks for updating this mini-improvement. It still works and the code still makes sense. RTBC 👍

[quicksketch]

Thanks folks! I've merged backdrop/backdrop#3533 into 1.x and 1.21.x.