Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice: Undefined index: base theme in backdrop_find_base_themes() (line 854 of theme.inc) #5238

Open
klonos opened this issue Sep 18, 2021 · 2 comments · May be fixed by backdrop/backdrop#3748

Comments

@klonos
Copy link
Member

klonos commented Sep 18, 2021

Description of the bug

I bumped into this while working on a PR for #5186.

I did a bit of research, and there are a few mentions of this error around d.org, but nothing conclusive, or people close the issue because they cannot reproduce (https://www.drupal.org/project/fusion/issues/916212 for example).

Steps To Reproduce

Pass the name of any theme that doesn't specify a base theme as the $key parameter in backdrop_find_base_themes():

$all_themes = list_themes();
$base_themes = backdrop_find_base_themes($all_themes, 'seven');
dpm($base_themes);

Actual behavior

image

Notice: Undefined index: base theme in backdrop_find_base_themes()
(line 854 of /app/docroot/core/includes/theme.inc).

Expected behavior

No notice. The function should still return the same result (array(NULL)).

@klonos
Copy link
Member Author

klonos commented Sep 18, 2021

PR up for review: backdrop/backdrop#3748

@klonos
Copy link
Member Author

klonos commented Sep 18, 2021

I'll need to fix the test failures before this is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant