Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect links to GitHub in module browser for core modules. #5623

Closed
olafgrabienski opened this issue May 11, 2022 · 6 comments · Fixed by backdrop/backdrop#4071
Closed

Comments

@olafgrabienski
Copy link

Description of the bug

This is a follow-up to #5003 which was merged only recently. The Github links for core modules don't work. They point to a non existent backdrop-contrib repo.

Steps To Reproduce

To reproduce the behavior:

  1. Go to admin/modules', and look for a core module, e.g. Administration Bar.
  2. Click on the "more" toggle link, and have a look at the line Links: BackdropCMS.org, GitHub
  3. Hit the Github link.

Actual behavior

The link points to https://github.com/backdrop-contrib/backdrop (Page not found)

Expected behavior

Not sure. Point the link to the core repo, or don't display a link.

Additional information

  • Backdrop CMS version: 1.22.0-preview
@olafgrabienski
Copy link
Author

The issue was first reported in #5003 (comment). See especially #5003 (comment) and below for possible reasons.

@ghost
Copy link

ghost commented May 11, 2022

The correct behaviour here is not to display links for core modules.

@ghost
Copy link

ghost commented May 11, 2022

Here's a PR: backdrop/backdrop#4071

@argiepiano
Copy link

LGTM 👍🏽

@olafgrabienski
Copy link
Author

Thanks for the PR, @BWPanda ! Let's make sure it goes in the 1.22 release. (Adding milestone.)

@ghost
Copy link

ghost commented May 16, 2022

Thanks @olafgrabienski and @argiepiano! I've merged backdrop/backdrop#4071 into 1.x.

@laryn laryn changed the title Project browser: Github links for core modules don't work Fixed incorrect links to GitHub in module browser for core modules. May 16, 2022
@laryn laryn changed the title Fixed incorrect links to GitHub in module browser for core modules. Fix incorrect links to GitHub in module browser for core modules. May 16, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants