-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect links to GitHub in module browser for core modules. #5623
Labels
Milestone
Comments
The issue was first reported in #5003 (comment). See especially #5003 (comment) and below for possible reasons. |
The correct behaviour here is not to display links for core modules. |
ghost
mentioned this issue
May 11, 2022
Here's a PR: backdrop/backdrop#4071 |
ghost
self-assigned this
May 11, 2022
LGTM 👍🏽 |
argiepiano
added
pr - ready to be committed
pr - works for me
and removed
pr - needs testing
pr - needs code review
labels
May 11, 2022
Thanks for the PR, @BWPanda ! Let's make sure it goes in the 1.22 release. (Adding milestone.) |
backdrop-ci
referenced
this issue
in backdrop/backdrop
May 16, 2022
…page. BY @BWPanda, @olafgrabienski & @argiepiano.
Thanks @olafgrabienski and @argiepiano! I've merged backdrop/backdrop#4071 into 1.x. |
ghost
added
status - fixed
and removed
pr - ready to be committed
pr - works for me
labels
May 16, 2022
laryn
changed the title
Project browser: Github links for core modules don't work
Fixed incorrect links to GitHub in module browser for core modules.
May 16, 2022
laryn
changed the title
Fixed incorrect links to GitHub in module browser for core modules.
Fix incorrect links to GitHub in module browser for core modules.
May 16, 2022
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
This is a follow-up to #5003 which was merged only recently. The Github links for core modules don't work. They point to a non existent
backdrop-contrib
repo.Steps To Reproduce
To reproduce the behavior:
admin/modules'
, and look for a core module, e.g. Administration Bar.Links: BackdropCMS.org, GitHub
Actual behavior
The link points to
https://github.com/backdrop-contrib/backdrop
(Page not found)Expected behavior
Not sure. Point the link to the core repo, or don't display a link.
Additional information
The text was updated successfully, but these errors were encountered: