Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate SVG animation to replace the throbber and use consistently in core #6524

Open
indigoxela opened this issue May 10, 2024 · 5 comments

Comments

@indigoxela
Copy link
Member

Description of the bug

We have SVG icons in core! 馃帀
But wait, there's this ugly little throbber, inherited from old Drupal, last time adapted back in 2015, but still in "Drupal blue" and sort of 90-s style.

https://github.com/backdrop/backdrop/blob/1.x/core/misc/throbber-active.gif

And there's yet another throbber - the one that views uses when opening views field dialogs. Different colors, different style.

https://github.com/backdrop/backdrop/blob/1.x/core/misc/loading-small.gif

Now that we dropped IE support, and browser support for animated SVG is pretty good, we could consider switching to animated SVG.

Advantage: better scaling, true transparency support, so it can look good on any background-color, in any size.

Disadvantage: to be determined

First step: define requirements

  • Browser support
  • Should be clear enough to be self-explaining
  • Not too distracting (A11Y)
  • Should be decent enough to fit any theme (no branding or color assumptions)
  • Should be easy to override in themes, if they need to
  • Should still play nicely with default themes (shouldn't look like a foreign object from the 90s)
  • ??? what's missing?
@indigoxela
Copy link
Member Author

@herbdool
Copy link

One of the Drupal links differentiates between the throbber and loader icon. Is that true? Do we need to replace both?

@herbdool
Copy link

This might be a good starting point https://gist.github.com/joelpittet/c75ff7c2f86282ff9499

@indigoxela
Copy link
Member Author

One of the Drupal links differentiates between the throbber and loader icon. Is that true? Do we need to replace both?

AFAIK, we're in no way bound to Drupal decisions. 馃槣

Note: as this is almost exclusively a design topic, I won't provide a PR. For sure not, if there's nothing decided, yet.
In case, someone here wants an animated SVG, ping me, though.

@klonos
Copy link
Member

klonos commented May 10, 2024

@klonos klonos changed the title Design: Evaluate SVG animation to replace the throbber and use consistently in core Evaluate SVG animation to replace the throbber and use consistently in core May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants