Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Ajax loading spinner position within dropbuttons #6441

Open
laryn opened this issue Apr 3, 2024 · 1 comment · May be fixed by backdrop/backdrop#4687
Open

Adjust Ajax loading spinner position within dropbuttons #6441

laryn opened this issue Apr 3, 2024 · 1 comment · May be fixed by backdrop/backdrop#4687

Comments

@laryn
Copy link
Contributor

laryn commented Apr 3, 2024

Description of the bug

From an issue in the Gin queue which seems to actually be a core issue: the Ajax spinner bloats the dropbutton height when active.

Steps To Reproduce

To reproduce the behavior:

  1. Go to Layouts and create a flexible layout template. Give it a name and save it to load the page where you can adjust regions.
  2. Click on Configure in the header region
  3. See the dropbutton expand strangely while the popup loads

Actual behavior

CleanShot 2024-03-25 at 08 57 26@2x

Expected behavior

The spinner should load next to the dropbutton's text without expanding the height.

@indigoxela
Copy link
Member

@laryn many thanks for starting this topic. (Oh, this ugly throbber... 😜)

Looking at your PR - it may be safe (it hopefully is), but may also be a breaker, as it applies to all AJAX requests via jQuery using a throbber.
This really needs thorough testing with all sorts of usages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment