Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMI] Color module needs to regenerate CSS files during config import #792

Closed
quicksketch opened this issue Mar 2, 2015 · 4 comments
Closed

Comments

@quicksketch
Copy link
Member

I ran across this while fixing #752. We need to have Color module regenerate CSS files when doing a full site config import.

To reproduce:

  • Change Bartik settings to a particular color scheme.
  • Export config.
  • Change Bartik settings again to a different color scheme.
  • Import the config from step 2.
  • Site is now missing CSS/colors in Bartik theme.
@quicksketch
Copy link
Member Author

PR filed at backdrop/backdrop#760, but it needs tests for this to be merged.

@hosef
Copy link

hosef commented Jun 7, 2018

There were a lot of conflicts with the original pull request because of some upstream changes so I copied the changes into a new branch and created a new pull request for this issue.
I also added a new test to the Color module, and made the tests that were there comply with Drupal coding standards.

@herbdool
Copy link

herbdool commented Jun 8, 2018

@hosef tested with @quicksketch's steps above and it works for me. And looks like the new tests pass. Great work!

@quicksketch quicksketch modified the milestones: 1.x-future, 1.10.2 Jun 14, 2018
backdrop-ci referenced this issue in backdrop/backdrop Jun 15, 2018
…figuration is imported, added tests for the new functionality, and made the existing tests comply with coding standards.

By @hosef and @quicksketch.
@quicksketch
Copy link
Member Author

I've merged backdrop/backdrop#2222 into 1.x for 1.11.0. Thanks @hosef! That test implementation is simpler than I had expected, nice work!

We have a merge conflict that prevents cherry-picking back into 1.10.x. If it's acceptable that this only applies to 1.11.0, then we can leave as-is. If we need a backport, could you reroll the PR against 1.10.x?

Closing for now, please reopen if we make a backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment