cli: remove no-duplicates lint rule

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
backstage · Feb 7, 2022 · fae2aee · fae2aee
1 parent 92abfff
commit fae2aee
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/pretty-glasses-admire.md b/.changeset/pretty-glasses-admire.md
@@ -0,0 +1,9 @@
+---
+'@backstage/cli': patch
+---
+
+Removed the `import/no-duplicates` lint rule from the frontend and backend ESLint configurations. This rule is quite expensive to execute and only provides a purely cosmetic benefit, so we opted to remove it from the set of default rules. If you would like to keep this rule you can add it back in your local ESLint configuration:
+
+```js
+  'import/no-duplicates': 'warn'
+```
diff --git a/packages/cli/config/eslint.backend.js b/packages/cli/config/eslint.backend.js
@@ -54,7 +54,6 @@ module.exports = {
     'no-console': 0, // Permitted in console programs
     'new-cap': ['error', { capIsNew: false }], // Because Express constructs things e.g. like 'const r = express.Router()'
     'import/newline-after-import': 'error',
-    'import/no-duplicates': 'warn',
     'import/no-extraneous-dependencies': [
       'error',
       {

diff --git a/packages/cli/config/eslint.js b/packages/cli/config/eslint.js
@@ -49,7 +49,6 @@ module.exports = {
     '@typescript-eslint/no-redeclare': 'error',
     'no-undef': 'off',
     'import/newline-after-import': 'error',
-    'import/no-duplicates': 'warn',
     'import/no-extraneous-dependencies': [
       'error',
       {