feat: add GroupListPicker component #14005

djamaile · 2022-10-05T14:43:40Z

Signed-off-by: djamaile rdjamaile@gmail.com

Hey, I just made a Pull Request!

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)
All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: djamaile <rdjamaile@gmail.com>

github-actions · 2022-10-05T14:51:21Z

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/plugin-org-react	plugins/org-react	minor	`v0.0.0`

Signed-off-by: djamaile <rdjamaile@gmail.com>

Signed-off-by: Mathias Bronner <mathiasb@spotify.com>

…master

Signed-off-by: Mathias Bronner <mathiasb@spotify.com>

Signed-off-by: djamaile <rdjamaile@gmail.com>

tudi2d

like this - some smaller things - hopefully I'm not to picky here. In general - did you consider splitting up the component in e.g. a GroupListPickerPopover (containing only the Popover & relevant state) & GroupListPicker? :)

plugins/catalog-react/src/components/GroupListPicker/GroupListPicker.tsx

…Picker.tsx Co-authored-by: Philipp Hugenroth <tudi2d@users.noreply.github.com> Signed-off-by: djamaile <rdjamaile@gmail.com>

plugins/catalog-react/src/components/GroupListPicker/GroupListPicker.tsx

Signed-off-by: djamaile <rdjamaile@gmail.com>

github-actions · 2022-10-14T15:49:14Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution!

djamaile · 2022-10-14T16:24:55Z

PRs can get stale?! Def not stale, just waiting on a review.

Rugvip

Thanks! 👍 Couple of nits

Another thing I'm wondering is how you feel about the placement of this in catalog-react vs something like org-react. It feels a bit off to have kind-specific components in catalog-react tbh, it's already a pretty large library. It also conflicts quite heavily with the UserListPicker, which is a different type of component that helps filter catalog index pages.

plugins/catalog-react/src/components/GroupListPicker/index.ts

.changeset/hungry-rocks-bathe.md

plugins/catalog-react/src/components/GroupListPicker/GroupListPicker.tsx

Rugvip · 2022-10-17T15:05:59Z

plugins/catalog-react/src/components/GroupListPicker/GroupListPicker.tsx

+          options={groups ?? []}
+          groupBy={option => option.spec.type}
+          getOptionLabel={option =>
+            option.spec.profile?.displayName ?? option.metadata.name


Probably want to include the namespace here as well if it's not default. humanizeEntityRef can help out there

Rugvip · 2022-10-17T15:06:35Z

plugins/catalog-react/src/components/GroupListPicker/GroupListPicker.tsx

+    });
+
+    return groupsList.items as GroupEntity[];
+  }, [catalogApi]);


This needs to depend on the groupTypes as well right?

Rugvip · 2022-10-17T15:10:34Z

plugins/catalog-react/src/components/GroupListPicker/GroupListPicker.tsx

+ *
+ * @public
+ */
+export type GroupListPickerProps = {


How is one supposed to get a hold of the selected group? 😅

Isn't it the defaultGroup prop? Or do you mean something different? 💭

As someone using this component in my own page, how do I know what group the user ended up picking?

djamaile · 2022-10-18T08:32:07Z

@Rugvip I agree that catalog-react might be an awkward place. Do you mean creating a new plugin called org-react or just the org plugin?

Rugvip · 2022-10-18T09:25:30Z

@djamaile yep a new org-react package. Same relation between that and org as between catalog-react and catalog. They're not separate plugins, but library packages provided by the plugins for others to use.

Signed-off-by: djamaile <rdjamaile@gmail.com>

djamaile · 2022-10-18T15:37:13Z

.github/CODEOWNERS

@@ -49,6 +49,7 @@ yarn.lock                                           @backstage/reviewers @backst
 /plugins/kubernetes                                 @backstage/reviewers @backstage/warpspeed
 /plugins/kubernetes-*                               @backstage/reviewers @backstage/warpspeed
 /plugins/newrelic-dashboard                         @backstage/reviewers @mufaddal7
+/plugins/org-react                                  @backstage/reviewers


@Rugvip Is this the right owner? Does it need an owner at all?

You can skip the explicit owner, there's a catch-all at the bottom that handles this

Signed-off-by: djamaile <rdjamaile@gmail.com>

djamaile · 2022-10-19T08:35:19Z

@Rugvip its all green, feel free to review again 😸

Signed-off-by: djamaile <rdjamaile@gmail.com>

Rugvip

🎉

CC @backstage/maintainers for the addition of the org-react package

plugins/org-react/src/plugin.ts

plugins/org-react/src/components/GroupListPicker/GroupListPicker.tsx

Signed-off-by: djamaile <rdjamaile@gmail.com>

Rugvip

Another round! 🍻

plugins/org-react/README.md

plugins/org-react/src/components/GroupListPicker/GroupListPicker.test.tsx

plugins/org-react/src/components/GroupListPicker/GroupListPicker.tsx

plugins/org-react/src/components/GroupListPicker/GroupListPickerButton.tsx

plugins/org-react/src/routes.ts

Signed-off-by: djamaile <rdjamaile@gmail.com>

mathiasbronner · 2022-10-26T08:07:34Z

whats the status now btw @Rugvip @djamaile? Just asking because i'm looking forward to using it soon 🥳

djamaile · 2022-10-26T08:12:08Z

@mathiasbronner Sorry, for the long wait! Besides me making silly mistakes we also had our offsite + BackstageCon in Detroit. So, things have been slower than normal. I hope to get this in the next release 😄

github-actions · 2022-11-02T08:20:52Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

Rugvip

Let's 😁

suuus · 2022-11-24T14:55:57Z

Thank you for contributing during Hacktoberfest 🍂! You can claim the Backstage Hacktoberfest Holopin at https://bck.st/hacktoberfest-holopin 🙌🏻

feat: add GroupListPicker component

3e9e820

Signed-off-by: djamaile <rdjamaile@gmail.com>

github-actions bot added the area:catalog Related to the Catalog Project Area label Oct 5, 2022

backstage-goalie bot assigned Rugvip Oct 5, 2022

djamaile and others added 9 commits October 6, 2022 09:34

chore: add changeset

bcc4686

Signed-off-by: djamaile <rdjamaile@gmail.com>

chore: add api-report

6797f03

Signed-off-by: djamaile <rdjamaile@gmail.com>

chore: add api-report

b8a2a96

Signed-off-by: djamaile <rdjamaile@gmail.com>

Merge branch 'backstage:master' into master

7e38273

fix layout for trigger button

a115ce5

Signed-off-by: Mathias Bronner <mathiasb@spotify.com>

Merge branch 'master' of github.com:djamaile/backstage into djamaile/…

e68c5c2

…master

clean up dev instance of component

0c0ac14

Signed-off-by: Mathias Bronner <mathiasb@spotify.com>

remove unused dep import

88d5586

Signed-off-by: Mathias Bronner <mathiasb@spotify.com>

rename label prop to placeholder and remove obsolete test case

aa2676d

Signed-off-by: Mathias Bronner <mathiasb@spotify.com>

djamaile marked this pull request as ready for review October 6, 2022 12:24

djamaile requested review from a team as code owners October 6, 2022 12:24

chore: run api-report again

3bc5d04

Signed-off-by: djamaile <rdjamaile@gmail.com>

tudi2d reviewed Oct 7, 2022

View reviewed changes

Update plugins/catalog-react/src/components/GroupListPicker/GroupList…

4d114d1

…Picker.tsx Co-authored-by: Philipp Hugenroth <tudi2d@users.noreply.github.com> Signed-off-by: djamaile <rdjamaile@gmail.com>

tudi2d reviewed Oct 7, 2022

View reviewed changes

plugins/catalog-react/src/components/GroupListPicker/GroupListPicker.tsx Outdated Show resolved Hide resolved

djamaile added 2 commits October 7, 2022 17:23

chore: clean up and respond to phillip comments

97a6246

Signed-off-by: djamaile <rdjamaile@gmail.com>

chore: make areadescribedby hard coded

6494177

Signed-off-by: djamaile <rdjamaile@gmail.com>

github-actions bot added the stale label Oct 14, 2022

github-actions bot removed the stale label Oct 14, 2022

Merge branch 'backstage:master' into master

07b12a7

Rugvip requested changes Oct 17, 2022

View reviewed changes

djamaile force-pushed the master branch from 08af859 to e96274f Compare October 18, 2022 13:07

djamaile added 5 commits October 18, 2022 15:14

fix: yarn lock

b4e86dc

Signed-off-by: djamaile <rdjamaile@gmail.com>

chore: update changeset

6e5f08d

Signed-off-by: djamaile <rdjamaile@gmail.com>

fix: export props and mark component public

8be4357

Signed-off-by: djamaile <rdjamaile@gmail.com>

chore: update the README

30de234

Signed-off-by: djamaile <rdjamaile@gmail.com>

fix: make vale happy or else

443a654

Signed-off-by: djamaile <rdjamaile@gmail.com>

djamaile commented Oct 18, 2022

View reviewed changes

djamaile requested a review from Rugvip October 18, 2022 16:12

chore: remove org-react from CODEOWNERS

e9cd236

Signed-off-by: djamaile <rdjamaile@gmail.com>

djamaile force-pushed the master branch from eb44a25 to e9cd236 Compare October 19, 2022 08:01

djamaile added 2 commits October 19, 2022 13:06

chore: give onChange prop the GroupListPicker component

420fe8a

Signed-off-by: djamaile <rdjamaile@gmail.com>

chore: clean up

c71676c

Signed-off-by: djamaile <rdjamaile@gmail.com>

Rugvip requested changes Oct 19, 2022

View reviewed changes

plugins/org-react/src/plugin.ts Outdated Show resolved Hide resolved

plugins/org-react/src/components/GroupListPicker/GroupListPicker.tsx Outdated Show resolved Hide resolved

Rugvip added the needs discussion Bring up for discussion during next sync label Oct 19, 2022

djamaile added 2 commits October 20, 2022 10:18

chore: drop initialGroup prop

eee9b5a

Signed-off-by: djamaile <rdjamaile@gmail.com>

chore: run api report command

1709bd9

Signed-off-by: djamaile <rdjamaile@gmail.com>

Rugvip removed the needs discussion Bring up for discussion during next sync label Oct 20, 2022

djamaile requested a review from Rugvip October 21, 2022 07:34

Rugvip requested changes Oct 24, 2022

View reviewed changes

chore: respond to comments

4c74b20

Signed-off-by: djamaile <rdjamaile@gmail.com>

djamaile requested a review from Rugvip October 26, 2022 07:58

github-actions bot added the stale label Nov 2, 2022

Rugvip removed the stale label Nov 2, 2022

Rugvip approved these changes Nov 4, 2022

View reviewed changes

Rugvip merged commit 4f9607f into backstage:master Nov 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add GroupListPicker component #14005

feat: add GroupListPicker component #14005

djamaile commented Oct 5, 2022 •

edited

Loading

github-actions bot commented Oct 5, 2022 •

edited

Loading

tudi2d left a comment

github-actions bot commented Oct 14, 2022

djamaile commented Oct 14, 2022

Rugvip left a comment

Rugvip Oct 17, 2022

Rugvip Oct 17, 2022

Rugvip Oct 17, 2022

djamaile Oct 18, 2022

Rugvip Oct 19, 2022

djamaile commented Oct 18, 2022

Rugvip commented Oct 18, 2022

djamaile Oct 18, 2022

Rugvip Oct 19, 2022

djamaile commented Oct 19, 2022

Rugvip left a comment

Rugvip left a comment

mathiasbronner commented Oct 26, 2022

djamaile commented Oct 26, 2022

github-actions bot commented Nov 2, 2022

Rugvip left a comment

suuus commented Nov 24, 2022

feat: add GroupListPicker component #14005

feat: add GroupListPicker component #14005

Conversation

djamaile commented Oct 5, 2022 • edited Loading

Hey, I just made a Pull Request!

✔️ Checklist

github-actions bot commented Oct 5, 2022 • edited Loading

Changed Packages

tudi2d left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2022

djamaile commented Oct 14, 2022

Rugvip left a comment

Choose a reason for hiding this comment

Rugvip Oct 17, 2022

Choose a reason for hiding this comment

Rugvip Oct 17, 2022

Choose a reason for hiding this comment

Rugvip Oct 17, 2022

Choose a reason for hiding this comment

djamaile Oct 18, 2022

Choose a reason for hiding this comment

Rugvip Oct 19, 2022

Choose a reason for hiding this comment

djamaile commented Oct 18, 2022

Rugvip commented Oct 18, 2022

djamaile Oct 18, 2022

Choose a reason for hiding this comment

Rugvip Oct 19, 2022

Choose a reason for hiding this comment

djamaile commented Oct 19, 2022

Rugvip left a comment

Choose a reason for hiding this comment

Rugvip left a comment

Choose a reason for hiding this comment

mathiasbronner commented Oct 26, 2022

djamaile commented Oct 26, 2022

github-actions bot commented Nov 2, 2022

Rugvip left a comment

Choose a reason for hiding this comment

suuus commented Nov 24, 2022

djamaile commented Oct 5, 2022 •

edited

Loading

github-actions bot commented Oct 5, 2022 •

edited

Loading