feat: add createdAfter filtering to the Notifications #23173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareklibra
requested review from
backstage-service and
a team
as code owners
Changed Packages
|
|
|
|
Uffizzi Cluster |
mareklibra
force-pushed
the
filterCreated
branch
2 times, most recently
from
c81e1a8
to
38261ab
Compare
|
Thanks for the contribution! |
mareklibra
force-pushed
the
filterCreated
branch
3 times, most recently
from
79e182c
to
b9a44a5
Compare
6 tasks
Signed-off-by: Marek Libra <marek.libra@gmail.com>
Signed-off-by: Marek Libra <marek.libra@gmail.com>
Signed-off-by: Marek Libra <marek.libra@gmail.com>
mareklibra
force-pushed
the
filterCreated
branch
from
b9a44a5
to
672f8e3
Compare
Rugvip
approved these changes
Feb 27, 2024
| @@ -98,6 +98,9 @@ export class DatabaseNotificationsStore implements NotificationsStore { | |||
| options: NotificationGetOptions | NotificationModifyOptions, | |||
| ) => { | |||
| const { user } = options; | |||
| const isSQLite = this.db.client.config.client.includes('sqlite3'); | |||
| // const isPsql = this.db.client.config.client.includes('pg'); | |||
There was a problem hiding this comment.
Suggested change
| // const isPsql = this.db.client.config.client.includes('pg'); |
🧹
| @@ -204,6 +204,13 @@ export async function createRouter( | |||
| opts.read = false; | |||
| // or keep undefined | |||
| } | |||
| if (req.query.created_after) { | |||
| const sinceEpoch = Date.parse(req.query.created_after.toString()); | |||
There was a problem hiding this comment.
Suggested change
| const sinceEpoch = Date.parse(req.query.created_after.toString()); | |
| const sinceEpoch = Date.parse(String(req.query.created_after)); |
Ever so slightly more safer way to convert to a string, in case of undefined / null
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
The notifications can be newly filtered based on the
Created Datefield.The filter on the UI side contains a list of predefined values instead of exact date+time selection.
✔️ Checklist
Signed-off-byline in the message. (more info)Depends on (needs rebase):