Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submenu text color #24366

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

JarunMadhesh
Copy link

Hey, I just made a Pull Request!

Fix for #24315
Made title and subtitles of sub menu's color editable using theme palette

backstage sc#1

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@JarunMadhesh JarunMadhesh requested review from a team as code owners April 18, 2024 21:28
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Apr 18, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/core-components packages/core-components patch v0.14.7-next.2
@backstage/theme packages/theme patch v0.5.4-next.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-24366 was successfully created. Learn more about Uffizzi virtual clusters
To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login
Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-24366 --kubeconfig=[PATH_TO_KUBECONFIG]
    After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-24366-c5094.uclusters.app.uffizzi.com

@JarunMadhesh JarunMadhesh changed the title Fix/submenu color Fix submenu text color Apr 18, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 2, 2024
@vinzscam vinzscam added area:discoverability Related to the Discoverability Project Area frontend design and removed stale labels May 3, 2024
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Make sure to run yarn build:api-reports locally and commit the changed files and remember to sign your commits to make the DCO check pass

@JarunMadhesh JarunMadhesh requested a review from a team as a code owner May 6, 2024 12:04
@github-actions github-actions bot added area:scaffolder Everything and all things related to the scaffolder project area and removed area:discoverability Related to the Discoverability Project Area labels May 6, 2024
@JarunMadhesh
Copy link
Author

@vinzscam I ran yarn build:api-reports and commited the changes with proper singing.
DCO is failing as I missed to sign the first 2 commits. Is there anything that I can do for that?

@clanghout
Copy link
Contributor

@JarunMadhesh It looks like the first 2 commits you made were not signed off. In order to reach those, you can run git rebase --signoff HEAD~7. I think you will run into some conflicts. If you fix those and finish the rebase, you can force push the changes to your branch and the MR should be good.

renovate bot and others added 9 commits May 10, 2024 20:05
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: blam <ben@blam.sh>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Adding rollup's preserveModules to enable tree-shaking in webpack.

Signed-off-by: Tomasz Szuba <tszuba@box.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Tomasz Szuba <tszuba@box.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Rugvip and others added 7 commits May 10, 2024 20:05
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
Signed-off-by: Jarun Madhesh <jarunmadhesh@gmail.com>
@JarunMadhesh
Copy link
Author

Done @clanghout @vinzscam DCO has passed, but test and verify WFs are not running. What do i do?

@benjdlambert
Copy link
Member

I think it's because this branch has some conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area design frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants