continued continued move of core services to backend-defaults #24849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Rugvip
reviewed
May 21, 2024
freben
changed the title
|
@Rugvip Ooh maybe. Hm which one should have the implementation though? That would suggest that the impl should stay in backend-common, since backend-defaults already has a dependency on it. Don't wanna introduce circular dependencies |
freben
force-pushed
the
freben/defaults-continued
branch
2 times, most recently
from
a561d8e
to
201ad33
Compare
camilaibs
approved these changes
May 21, 2024
freben
force-pushed
the
freben/defaults-continued
branch
7 times, most recently
from
e5fce40
to
02103be
Compare
|
I think I'll start over on this one now that #24848 settled on a slightly different structure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #24724, moving over some implementations from backend-common (which is scheduled for removal) to backend-defaults.
Made this into a PR of its own since it turned out to be pretty large. Note that it's on top of #24848, which should be merged first. But therefore, piggybacking on its changesets.
This PR does NOT rename the types in backend-plugin-api, e.g.
SearchOptions->UrlReaderSearchOptions, since that's an additional pretty large change that can come by itself so things are easier to review in isolation.