Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the jwks external auth to use singular nouns #24874

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

freben
Copy link
Member

@freben freben commented May 22, 2024

This is on top of #24702 (which should be merged first), and a follow-up to #24681. This also ensures that the access restrictions work and the updated config reading structure is used accordingly.

It reuses the concept from the other handlers, where the noun is singular but it supports both strings and string arrays (either literal arrays or strings separated by commas/spaces).

Piggybacks on the changeset from #24681

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
@freben freben requested review from a team as code owners May 22, 2024 14:45
@freben freben requested review from benjdlambert and vinzscam and removed request for a team May 22, 2024 14:45
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 22, 2024
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yep, nice 👍

Base automatically changed from freben/service-token-scopes to master May 23, 2024 13:49
@freben freben merged commit 917b3ed into master May 23, 2024
23 checks passed
@freben freben deleted the freben/singular-jwks branch May 23, 2024 13:50
Copy link
Contributor

Uffizzi Cluster pr-24874 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants