Changing shrinking screen size entity title behavior #24882
Conversation
Changed Packages
|
Signed-off-by: Jordan Snow <jordans@spotify.com>
SnowBlitzer
force-pushed
the
jordans/nameWrap
branch
from
8ab767b
to
5dcfdd3
Compare
|
If I can make a suggestion, I would definitely prefer that the title show an ellipsis and have a tooltip show the full name when you roll over with the mouse. Part of the reason is that on long names like this it is hard to tell if there is an actual line-break in the name. |
|
@joshjung an entity name shouldn't support line breaks in the name in the standard catalog config. Is this something that you're seen users override? The hover tool tip still shows the full, none-wrap and none-formatted name if there is any confusion there. Seems like adding a step to a user's information consumptions for an edge case feels bad from their perspective |
|
Yeah it's just a personal preference having done frontend for a long time, I don't enjoy when large titles wrap a ton within words as it can cause confusion and it causes the page layout to end up looking odd. Feel free to carry on. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
There was a problem hiding this comment.
Hi @SnowBlitzer, thanks for opening a pull request 🙂 .
I would like to recommend adding an optional property to the component to disable title wrapping rather than changing the default style. Something like:
<EntityLayoutTitle disableTitleWrapping .../>What do you think?
|
@camilaibs I think this is a great compromise! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hey, I just made a Pull Request!
It seems some work done for screen sizing has been lost (ex this PR) and longer names get cut off for entities and the formatting of the header can become jumbled.
For both better readability and easier accessibility, I've made it so the name wraps to keep the user provided with full information and formatted the owner, lifecycle, and menu to always stay together and move as unit.
Before:
After:
✔️ Checklist
Signed-off-byline in the message. (more info)