Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Travis #18

Merged
merged 7 commits into from
Aug 10, 2014
Merged

Enable Travis #18

merged 7 commits into from
Aug 10, 2014

Conversation

rtfeldman
Copy link
Collaborator

Also slightly fleshed out the README.

npm test currently fails (it times out waiting for something to happen), so this probably shouldn't be merged until we have tests passing.

@hojberg
Copy link
Collaborator

hojberg commented Aug 9, 2014

I think @tommyh set npm test up as a watch process, maybe we can separate out those two tasks?

@rtfeldman
Copy link
Collaborator Author

Good call! Split out in ac0523d

@tommyh
Copy link
Contributor

tommyh commented Aug 9, 2014

On the jasmine-node branch i have some changes to split out client vs server tests. I'll merge these changes today!

@tommyh
Copy link
Contributor

tommyh commented Aug 9, 2014

I'll also investigate the travis timeout, I have a guess of what it is.

@tommyh
Copy link
Contributor

tommyh commented Aug 10, 2014

@rtfeldman - there were 2 issues.

  1. karma-browserify was taking so long to preprocess the files, that it was timing out on travis. Locally it'd take about 45 seconds on my macbook air...
  2. the stable version of phantomjs doesn't have Function.prototype.bind, so it needs a polyfill.

I have merged this branch into my jasmine-node branch, but that isn't stable yet. But you can merge this branch as you see fit.

@rtfeldman
Copy link
Collaborator Author

👍

Don't want to merge until tests pass, because that will just make every branch generate a bunch of failures...so I'm closing this in favor of the jasmine-node branch. Once that's passing and merged, Travis tests for all!

@rtfeldman rtfeldman closed this Aug 10, 2014
@tommyh
Copy link
Contributor

tommyh commented Aug 10, 2014

Oh, i think my wording was confusing. :)

enable-travis branch is passing and stable.
jasmine-node is "passing" but not stable.

I'd recommend merging enable-travis because it's an iterative improvement which can help everyone now, and I'll get jasmine-node ready tomorrow.

@tommyh tommyh reopened this Aug 10, 2014
rtfeldman added a commit that referenced this pull request Aug 10, 2014
@rtfeldman rtfeldman merged commit a4879c0 into master Aug 10, 2014
@rtfeldman
Copy link
Collaborator Author

Sold!

@rtfeldman rtfeldman deleted the enable-travis branch August 10, 2014 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants