Add base SurveyEditor with draggable questions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename <SurveyHeader/> to <Divider/> - Move all components to client/app/components - Switch to fixed with layout
|
@hojberg Agreed. I'll have a chance to go over this in detail tonight. I gave your PR a quick look over this morning and it looks good. |
|
|
||
| var React = require("react"); | ||
|
|
||
| var Divider = React.createClass({ |
There was a problem hiding this comment.
Good name change from SurveyHeader to Divider
|
I like your name choice, calling each row, or item of a survey a "question". I think I'll update #19 to follow your pattern. |
hojberg
added a commit
that referenced
this pull request
Aug 13, 2014
Add base SurveyEditor with draggable questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<SurveyHeader/>to<Divider/>@somethingkindawierd We have quite a bit of overlap - I left all your stuff in when I rebased, but we should talk and agree on an appraoch