Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy.yml #113

Merged
merged 1 commit into from
May 5, 2023
Merged

Update deploy.yml #113

merged 1 commit into from
May 5, 2023

Conversation

melekr
Copy link
Contributor

@melekr melekr commented May 5, 2023

  • Disable building dynamic frameworks

@melekr melekr marked this pull request as ready for review May 5, 2023 19:55
@melekr melekr requested a review from rick-bt May 5, 2023 19:57
@melekr melekr merged commit 6d455b0 into master May 5, 2023
4 checks passed
@melekr melekr deleted the Disable_dynamic_frameworks branch May 5, 2023 19:58
@vlussenburg
Copy link
Contributor

vlussenburg commented May 8, 2023

@melekr Noooooooo! :)

Hi, I'm Vincent, a previous maintainer of this library :)

These builds was used by customers on Unreal engine that had to integrate this way. The tickets can be found in hack for it, I remember a big name customer specifically asking for it and it being prioritized via Zendesk as well. Are you certain you want to remove it?

@vlussenburg
Copy link
Contributor

(and if you're certain you may want to remove .github/workflows/Podfile as well)

@melekr
Copy link
Contributor Author

melekr commented May 9, 2023

@vlussenburg Hi Vincent 👋🏽 Nice to finally virtually meet you!

We've encountered some issues building these static frameworks that's the reason we disabled them.

Now that we have SPM, we're thinking about shifting those customers towards SPM where they can build our library however they like (dynamically or statically) for any architecture of their choice.

Please do let me know if I missed something, really appreciate the feedback :)

@rick-bt
Copy link
Contributor

rick-bt commented May 9, 2023

Thank you @vlussenburg - you seem to have ascended from "maintainer" to "guardian angel". Reassuring! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants