add rsync client and another constructor for rsync server #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaypatel07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alaypatel07
force-pushed
the
rsync-client
branch
from
9267845
to
fdf0c4b
Compare
alaypatel07
force-pushed
the
rsync-client
branch
from
fdf0c4b
to
5b5c837
Compare
alaypatel07
changed the title
alaypatel07
force-pushed
the
rsync-client
branch
3 times, most recently
from
0a9737b
to
dda64c6
Compare
Signed-off-by: Alay Patel <alay1431@gmail.com>
Signed-off-by: Alay Patel <alay1431@gmail.com>
This avoid defaulting bools to a value if unused. Signed-off-by: Alay Patel <alay1431@gmail.com>
alaypatel07
force-pushed
the
rsync-client
branch
from
dda64c6
to
02b3cf9
Compare
JohnStrunk
reviewed
Feb 23, 2022
- refactor if condition for len of containerStatuses - store rsync password in secret - drop get from get* methods - use more constants Signed-off-by: Alay Patel <alay1431@gmail.com>
alaypatel07
force-pushed
the
rsync-client
branch
from
6de3205
to
6ff5ca4
Compare
Signed-off-by: Alay Patel <alay1431@gmail.com>
JohnStrunk
reviewed
Mar 1, 2022
| @@ -254,6 +303,12 @@ func NewServer(ctx context.Context, c client.Client, logger logr.Logger, | |||
| namespace = pvcList.Namespaces()[0] | |||
| } | |||
|
|
|||
| if podOptions.SCCName == nil || (podOptions.SCCName != nil && *podOptions.SCCName == "") { | |||
| //TODO: raise a warning event | |||
There was a problem hiding this comment.
I'm not sure whether this would be a warning or not... If you're not on OpenShift, lack of an SCC name doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR adds Rsync client implementations
Is there anything that requires special attention?
This depends on changes in #13
Related issues:
the second half of #12