Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for SMTP with SSL. #423

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
Contributor

airblade commented Mar 25, 2013

Fastmail requires SMTP to use SSL but not STARTTLS. This change enables
ones to turn on SSL without automatically starting TLS.

Here are some relevant links:

http://blog.fastmail.fm/2012/05/21/enforcing-ssltls-encryption-of-all-connections/
https://www.fastmail.fm/docs/encryption.html#ot

Add support for SMTP with SSL.
Fastmail requires SMTP to use SSL but not STARTTLS.  This change enables
ones to turn on SSL without automatically starting TLS.

Here are some relevant links:

http://blog.fastmail.fm/2012/05/21/enforcing-ssltls-encryption-of-all-connections/
https://www.fastmail.fm/docs/encryption.html#ot
@ghost

ghost commented Mar 25, 2013

Would it make more sense to have a single option for this?

notify_by Mail do |mail|
  mail.encryption = :starttls # or :ssl (or :tls)

Setting Mail's :ssl or :tls option to true negates it's enable_starttls_auto setting.
Net::SMTP does not distinguish between :ssl or :tls, but having the option accept both might be easier for users following various email client setup instructions to understand.

https://github.com/meskyanichi/backup/compare/mail_notifier

What do you think?

Contributor

airblade commented Mar 26, 2013

Good idea – I agree.

@ghost ghost closed this in 1c6be33 Mar 26, 2013

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment