Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ClientWifiAlias): added an extra parameters to allow wifi backup #94

Merged
merged 3 commits into from
Apr 15, 2017

Conversation

martintamare
Copy link
Contributor

We use backuppc a lot but we are missing one feature.
We have a lots of laptop which connect randomly on wired connections or on wireless connections.

We try advanced DNS stuff but were unable to have a decent result.
Thus we made this patch.

Similar to ClientNameAlias, we implemented ClientWifiAlias.

What does it do ?

Instead a fetching a unique hostIP, we build an array of valid IP and loop on them.

I know it's far from being ready to merge but I'd like feedback on how to improve it :

  • ClientWifiAlias : maybe make this an array ? or a better name ?

Cheers,

@moisseev
Copy link
Member

What if we just add ability to specify $Conf{ClientNameAlias} as an array (it should accept both: a string or an array of strings) instead of adding the new $Conf{ClientWifiAlias} parameter? It will allow to add any number of alternative host names or IPs.

$Conf{ClientNameAlias} = 'hostname';
$Conf{ClientNameAlias} = ['hostname1', 'hostname2', 192.168.1.1];

@martintamare
Copy link
Contributor Author

I like that !
Doing soon ...

@martintamare
Copy link
Contributor Author

Seems ok to me, I backported this to v3, it worked like a charmed :)
By the way, any news on a Debian package of the v4 ?

@craigbarratt
Copy link
Contributor

I definitely prefer the approach of allowing $Conf{ClientNameAlias} to be an array, rather than adding a new config variable. I'll update the config editor to handle the array case.

@craigbarratt craigbarratt merged commit ffedd6d into backuppc:master Apr 15, 2017
craigbarratt added a commit that referenced this pull request Apr 16, 2017
@craigbarratt
Copy link
Contributor

craigbarratt commented Apr 16, 2017

I pushed some edits; in particular, hosts in ClientNameAlias are processed in order, so the first good one matches (previously, using a hash, the order is not determinant). Can you retest before I release this? Thanks.

@martintamare
Copy link
Contributor Author

Checking soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants