Skip to content

Commit

Permalink
fix fromArray when a previous observer has takes exactly N values (#724)
Browse files Browse the repository at this point in the history
  • Loading branch information
semmel authored and raimohanska committed Dec 13, 2018
1 parent cdb042f commit 605c75e
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 3 deletions.
2 changes: 1 addition & 1 deletion spec/SpecHelper.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ verifyLateEval = (srcF, expectedEvents) ->
events.push(event)


verifySingleSubscriber = (srcF, expectedEvents) ->
module.exports.verifySingleSubscriber = verifySingleSubscriber = (srcF, expectedEvents) ->
verifyStreamWith "(single subscriber)", srcF, expectedEvents, (src, events, done) ->
src.subscribe (event) ->
if event.isEnd
Expand Down
25 changes: 23 additions & 2 deletions spec/specs/take.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ expect = require("chai").expect
unstable,
fromArray,
t,
once
once,
verifySingleSubscriber
} = require("../SpecHelper")

describe "EventStream.take", ->
Expand All @@ -31,10 +32,30 @@ describe "EventStream.take", ->
throw "testing" if value == "lol" # special string that will be catched by TickScheduler
s
["wut"], unstable) # the outputs don't really matter - it's just that the stream terminates normally
describe "works with synchronous source", ->
describe "works with asynchronous fromArray source", ->
expectStreamEvents(
-> fromArray([1,2,3,4]).take(2)
[1,2])

stream = fromArray([1,2,3,4])
verifySingleSubscriber(
-> stream.take(2)
[1, 2])
verifySingleSubscriber(
-> stream.take(2)
[3, 4])
verifySingleSubscriber(
-> stream.take(2)
[])

streamToo = fromArray([1,2])
verifySingleSubscriber(
-> streamToo.take(4)
[1, 2])
verifySingleSubscriber(
-> streamToo.take(2)
[])

it "toString", ->
expect(Bacon.never().take(1).toString()).to.equal("Bacon.never().take(1)")

Expand Down
4 changes: 4 additions & 0 deletions src/fromarray.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export default Bacon.fromArray = function(values) {
if (pushing) {
return;
}
if (i === values.length) {
sink(endEvent());
return false;
}
pushing = true;
while (pushNeeded) {
pushNeeded = false;
Expand Down

0 comments on commit 605c75e

Please sign in to comment.