Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking references when using update-db #28

Closed
johnlees opened this issue Aug 7, 2018 · 2 comments
Closed

Picking references when using update-db #28

johnlees opened this issue Aug 7, 2018 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@johnlees
Copy link
Member

johnlees commented Aug 7, 2018

When running --update-db after --assign-query the sketches produced are inconsistent with the distances and the network.

I think this is because the reference is still randomly sampled from cliques rather than ensuring the previous reference is used when available. It's definitely desirable to avoid needing to resketch the original refs when updating both computationally and because it would mean the assemblies would need to be distributed with the database.

Need to update extractReferences() in network.py to use existing references from cliques where already defined.

@johnlees johnlees added the bug Something isn't working label Aug 7, 2018
@johnlees johnlees self-assigned this Aug 7, 2018
@johnlees
Copy link
Member Author

johnlees commented Aug 7, 2018

This may actually be a problem with inconsistent datasets/graphs, in which case this would be covered by #27

@johnlees
Copy link
Member Author

johnlees commented Aug 9, 2018

Confirmed, this is a bug (previously had only tested with --full-db, I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant