Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Assorted improvements in MSVC #67

Merged
merged 2 commits into from
Jun 5, 2023
Merged

ci: Assorted improvements in MSVC #67

merged 2 commits into from
Jun 5, 2023

Conversation

amyspark
Copy link
Collaborator

@amyspark amyspark commented Jun 4, 2023

Hi @dragonmux,

This PR fixes the following nitpicks with regards to the MSVC jobs:

  • they still submitted coverage for the test folder, which we already exclude in the rest of the jobs.
  • for the cases where they time out (codegen or deadlock issues?) we'll now submit the test executables and PDB as well, for local testing.

Let me know what you think.

Why on earth were we sending these to begin with?
@amyspark amyspark requested a review from dragonmux June 4, 2023 23:59
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #67 (606e0cf) into main (eea279f) will decrease coverage by 2.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   95.48%   92.62%   -2.87%     
==========================================
  Files          75       48      -27     
  Lines        5831     3390    -2441     
  Branches      610      610              
==========================================
- Hits         5568     3140    -2428     
+ Misses        206      193      -13     
  Partials       57       57              

see 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple change set, approved for merge. We'll get this merged once we've seen CI go green (ignoring codecov decreases)

@dragonmux dragonmux added the bug Something isn't working label Jun 5, 2023
@dragonmux dragonmux merged commit 606e0cf into main Jun 5, 2023
@dragonmux dragonmux deleted the amyspark/msvc-ci branch June 5, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants