Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuring the sample format for librespot streams #929

Closed
nkvoll opened this issue Oct 19, 2021 · 3 comments
Closed

Enable configuring the sample format for librespot streams #929

nkvoll opened this issue Oct 19, 2021 · 3 comments

Comments

@nkvoll
Copy link
Contributor

nkvoll commented Oct 19, 2021

librespot supports (among others) 24 bit sample format (through command line options).

Currently snapserver has the sampleformat of 44100:16:2 hardcoded for librespot streams. This seems like a reasonable default because if a user changes the default sampleformat = in the configuration file, it's all too easy to break the setup.

However, since librespot exposes it, it would be great if there existed a way to take advantage of the higher sample format.

@badaix
Copy link
Owner

badaix commented Dec 28, 2021

@nkvoll please find my comments in the PR #930

@badaix
Copy link
Owner

badaix commented Jul 15, 2022

no response => closed

@badaix badaix closed this as completed Jul 15, 2022
@nkvoll
Copy link
Contributor Author

nkvoll commented Jul 17, 2022

+1 on closing for now and sorry for not being more on the ball on the PR responses and following up on them. I've a temporary pause on building the system on my end because I was virtualizing the servers with the snapclients and it became impossible for me to tell whether I had messed something up or the virtualization (and following lack of real time / low latency audio) was causing some random stuttering and buffering issues.

I hope to pick this up later on this year or early next, but I will have to rebuild my physical system on bare metal first, so I cannot promise when I will be able to find the time for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants