Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Android Q #17

Closed
wants to merge 3 commits into from
Closed

Fixes for Android Q #17

wants to merge 3 commits into from

Conversation

derWeihnachtsmann
Copy link
Contributor

Binary cannot be loaded from "external" anymore.. :(
fixes #16

@badaix
Copy link
Owner

badaix commented Jan 13, 2020

where are the binaries coming from?

@derWeihnachtsmann
Copy link
Contributor Author

derWeihnachtsmann commented Jan 13, 2020

where are the binaries coming from?

I just copied them from /src/main/assets/bin. I had some struggle with android Studio, sorry for the misconvenience there.

@badaix
Copy link
Owner

badaix commented Jan 13, 2020

Thanks,

renaming the binaries to libXXX.so is ugly!
But I googled and on reddit they came up with the same workaround.

This means that we won't need this copy and setup stuff anymore?

In MainActivity.java

        new Thread(new Runnable() {
            @Override
            public void run() {
                Log.d(TAG, "copying snapclient");
                Setup.copyBinAsset(MainActivity.this, "snapclient", "snapclient");
                Log.d(TAG, "done copying snapclient");
            }
        }).start();

And all of those CopyAsset and CopyBinAsset in Setup.java?

@badaix
Copy link
Owner

badaix commented Jan 13, 2020

After following GitHub's manual merge instructions because of a conflict, I get:
Unsupported Modules Detected: Compilation is not supported for following modules: libs, libsnapcast. Unfortunately you can't have non-Gradle Java modules and Android-Gradle modules in one project.

@@ -3,6 +3,8 @@
<component name="ProjectModuleManager">
<modules>
<module fileurl="file://$PROJECT_DIR$/Snapcast/Snapcast.iml" filepath="$PROJECT_DIR$/Snapcast/Snapcast.iml" />
<module fileurl="file://$PROJECT_DIR$/libs/libs.iml" filepath="$PROJECT_DIR$/libs/libs.iml" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file seems to be missing

@@ -3,6 +3,8 @@
<component name="ProjectModuleManager">
<modules>
<module fileurl="file://$PROJECT_DIR$/Snapcast/Snapcast.iml" filepath="$PROJECT_DIR$/Snapcast/Snapcast.iml" />
<module fileurl="file://$PROJECT_DIR$/libs/libs.iml" filepath="$PROJECT_DIR$/libs/libs.iml" />
<module fileurl="file://$PROJECT_DIR$/libs/libsnapcast/libsnapcast.iml" filepath="$PROJECT_DIR$/libs/libsnapcast/libsnapcast.iml" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this as well

@@ -1 +1,2 @@
include ':Snapcast'
include ':libs:libsnapcast'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle is complaining about this: Unsupported Modules Detected: Compilation is not supported for following modules: libs, libsnapcast. Unfortunately you can't have non-Gradle Java modules and Android-Gradle modules in one project.

@badaix badaix closed this Jan 14, 2020
@badaix
Copy link
Owner

badaix commented Jan 14, 2020

@derWeihnachtsmann thanks, it's now merged and builds. Because of my formerly unpushed changes, there was a merge conflict, and now you are for some reason not listed as contributor. Sorry for that, I don't know how to fix this.

@badaix badaix mentioned this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No audio on Pixel 3
3 participants