Apply suggestions from code review

badass-courses · Mar 17, 2024 · f871ab8 · f871ab8
1 parent 1d4d68f
commit f871ab8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/apps/course-builder-web/src/inngest/functions/concepts/get-or-create-tag.ts b/apps/course-builder-web/src/inngest/functions/concepts/get-or-create-tag.ts
@@ -9,15 +9,12 @@ export const getOrCreateConcept = inngest.createFunction(
     event: CONCEPT_TAGS_REQUESTED,
   },
   async ({ event, step }) => {
-    let new_concept
-    let related_concepts
-
-    await step.run('check for similar concepts', async () => {
-      related_concepts = await get_related_concepts(event.data.key)
+    const related_concepts = await step.run('check for similar concepts', async () => {
+      return await get_related_concepts(event.data.key)
     })
 
-    await step.run('create new concept', async () => {
-      new_concept = await add_concept(event.data.key)
+    const new_concept = await step.run('create new concept', async () => {
+      return await add_concept(event.data.key)
     })
 
     // TODO:

diff --git a/apps/course-builder-web/src/inngest/functions/split_video.ts b/apps/course-builder-web/src/inngest/functions/split_video.ts
@@ -13,7 +13,7 @@ export const computeVideoSplitPoints = inngest.createFunction(
   },
   async ({ event, step }) => {
     const split_points = await step.run('determining split points', async () => {
-      determineSplitPoints(event.data.transcript)
+      return determineSplitPoints(event.data.transcript)
     })
 
     // open question - do we want to return the split poinst here, or do we want to kick off an actual splitting of the video within this function?