Use *ring* in the canonical way. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Do HMAC verification using |ring::hmac::verify| as recommended in the *ring* documentation. This allows the dependency on constant_time_eq to be dropped. 2. Instead of creating a temporary HMAC key in each sign/verify operation, calculate the HMAC key once and reuse the same key multiple times. This is more efficient as the creation of an HMAC key is not free. 3. Do not store |salt| seperately. |salt| has already been mixed into |s_key| and |v_key| so it isn't needed any more.
|
Thank you! |
badboy
added a commit
that referenced
this pull request
Oct 23, 2015
Use *ring* in the canonical way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ring documentation. This allows the dependency on
constant_time_eq to be dropped.
operation, calculate the HMAC key once and reuse the same key multiple
times. This is more efficient as the creation of an HMAC key is not
free.
|s_key| and |v_key| so it isn't needed any more.