New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nonGlobalStepDefinitions): .features files now work with webpack #404
fix(nonGlobalStepDefinitions): .features files now work with webpack #404
Conversation
It seems like this conditionally removes the cache busting in case Weback is detected. The cache busting is however important and serves a particular purposes when using |
this is what i tested with EDIT: here's what I based my test on ->
|
@badeball i've just encountered some weird behavior, let me have another look |
65ee0a4
to
c789554
Compare
@badeball if you could do another review, that would be awesome, im now deleting the moduleid entry from require.cache |
c789554
to
620d22c
Compare
The current state of things is indeed how I imagined it would be. Did it solve the problem you mentioned above? |
@badeball yes it did, now tests run as expected. |
Thanks so much for the PR @sebastiandero , glad you got it. |
🎉 This PR is included in version 2.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I have tried with our project (80+ scenarios) they now seem to work.
tests in the repo also pass (some dont because of windows vs linux path slashes, but that was the case before)
#304