Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAL Action attempts to read empty response body on HTTP 204 #414

Closed
pschwyter opened this issue Dec 17, 2021 · 0 comments · Fixed by #418
Closed

HAL Action attempts to read empty response body on HTTP 204 #414

pschwyter opened this issue Dec 17, 2021 · 0 comments · Fixed by #418
Assignees
@evert
Labels
bug

Comments

@pschwyter
Copy link

Like the title says, Ketting attempts to read/parse the empty response body from a HTTP 204 response. But it shouldn't

Example:
image
@evert evert added the bug label Dec 17, 2021
@evert evert self-assigned this Dec 17, 2021
evert added a commit that referenced this issue Jan 6, 2022
@evert
Don't error when 204 is returned with a content-type.
aa9bec8 
Fixes #414.

Many servers will return a `Content-Type` for 204 responses, even though
this is probably incorrect, but at least meaningless.

This fix ensures that we're not attempting to parse the response body
if a 204 is returned.
@evert evert mentioned this issue Jan 6, 2022
Merged
@evert evert closed this as completed in #418 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evert evert

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't error when 204 is returned with a content-type. badgateway/ketting
2 participants
@evert @pschwyter