Increase 'max listeners'. #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Ketting is used in the frontend, we want to encourage it being used as a store for central state. If a piece of data is used in different places, this will usually result in events being registered. The default of 10 is quite low, and standard applications often start emitting warnings for 'max listeners'. This PR increases it to 500 for the Resource object. This is plenty of room.
|
hurray! This warning is v annoying |
mhum
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Ketting is used in the frontend, we want to encourage it being used as a store for central state. If a piece of data is used in different places, this will usually result in events being registered.
The default of 10 is quite low, and standard applications often start emitting tons of annoying warnings for 'max listeners'. This is annoying and creates distrust. Having a lot of listeners on a single EventEmitter can be indicative of a memory leak, but having lots of listeners itself is not cause for concern.
This PR increases it to 500 for the Resource object. This is plenty of room.