Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): php-cs-fixer run #102

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix(ci): php-cs-fixer run #102

merged 1 commit into from
Jan 5, 2024

Conversation

JellyBellyDev
Copy link
Collaborator

No description provided.

@JellyBellyDev JellyBellyDev merged commit 5bdeee9 into master Jan 5, 2024
4 checks passed
@JellyBellyDev JellyBellyDev deleted the fix/php-cs-fixer-run branch January 5, 2024 14:14
Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right fix IMHO.

In CI we have a step for coding standards, then we re-check the CS for every version of PHP, which seems useless to me.
I guess that at one point we added the CS step and we forgot to remove the repeated checks.

So, in the end, we should remove the multiple checks and keep only the first one.

@JellyBellyDev
Copy link
Collaborator Author

The problem was in all versions of php.
php-cs-fixer has been updated and apparently changed a default behavior.
So in my opinion it's the right fix! ;)
Not having the composer.lock versioned can happen!

@garak
Copy link
Collaborator

garak commented Jan 5, 2024

That was not the problem, since the check for php-cs-fixer that we're performing in the action step never failed.
And, again, it's useless to run php-cs-fixer four times when we can run it once.

@JellyBellyDev
Copy link
Collaborator Author

I agree with you that it is useless to run it four times but it confirms that that was the problem, I also encountered it locally on every single supported version of php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants