Refactor render and handle to thrown an exception

services/pypi/pypi-framework-versions.service.js

@@ -1,3 +1,4 @@
+import { InvalidResponse } from '../index.js'
 import PypiBase from './pypi-base.js'
 import { sortPypiVersions, parseClassifiers } from './pypi-helpers.js'
 
@@ -73,18 +74,10 @@ export default class PypiFrameworkVersion extends PypiBase {
   static render({ name, versions }) {
     name = name ? name.toLowerCase() : ''
     const label = `${name} versions`
-    if (versions.length > 0) {
-      return {
-        label,
-        message: sortPypiVersions(versions).join(' | '),
-        color: 'blue',
-      }
-    } else {
-      return {
-        label,
-        message: 'missing',
-        color: 'red',
-      }
+    return {
+      label,
+      message: sortPypiVersions(versions).join(' | '),
+      color: 'blue',
     }
   }
 
@@ -99,6 +92,12 @@ export default class PypiFrameworkVersion extends PypiBase {
     const packageData = await this.fetch({ egg: packageName })
     const versions = parseClassifiers(packageData, regex)
 
+    if (versions.length === 0) {
+      throw new InvalidResponse({
+        prettyMessage: `${name} versions are missing for ${packageName}`,
+      })
+    }
+
     return this.constructor.render({ name, versions })
   }
 }

services/pypi/pypi-framework-versions.tester.js

@@ -22,7 +22,10 @@ t.create('supported django versions (valid, no package version specified)')
 
 t.create('supported django versions (no versions specified)')
   .get('/django/django/1.11.json')
-  .expectBadge({ label: 'django versions', message: 'missing' })
+  .expectBadge({
+    label: 'versions',
+    message: 'Django versions are missing for django/1.11',
+  })
 
 t.create('supported django versions (invalid)')
   .get('/django/not-a-package.json')