Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 2021 support to [GitHubHacktoberfest] #7086

Merged
merged 2 commits into from
Oct 4, 2021
Merged

add 2021 support to [GitHubHacktoberfest] #7086

merged 2 commits into from
Oct 4, 2021

Conversation

calebcartwright
Copy link
Member

Resolves #7083

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Oct 1, 2021
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7086 October 1, 2021 04:10 Inactive
@shields-ci
Copy link

shields-ci commented Oct 1, 2021 •
edited
Loading

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @calebcartwright!

Generated by 🚫 dangerJS against 54a22af

chris48s
chris48s approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you reckon we should just change this to allow [0-9]{4} or something so we don't have to bump it every year?

@calebcartwright
Copy link
Member Author

Do you reckon we should just change this to allow [0-9]{4} or something so we don't have to bump it every year?

We debated doing this when we first added the badge, but opted to stick to a fixed list to avoid sending out useless queries. I'm open to revisiting this, but also don't find this too painful (especially when we manage to remember pre-October 1 😆)

@repo-ranger repo-ranger bot merged commit 42a9ca6 into master Oct 4, 2021
@repo-ranger repo-ranger bot deleted the hacktoberfest-2021 branch October 4, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge Request: Hacktoberfest 2021! 🎃
4 participants
@calebcartwright @shields-ci @chris48s @shields-cd