Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing incorrect JetBrains Plugin rating values for [JetBrainsRating] #7140

Merged
merged 3 commits into from Oct 15, 2021
Merged

Fixing incorrect JetBrains Plugin rating values for [JetBrainsRating] #7140

merged 3 commits into from Oct 15, 2021

Conversation

ChrisCarini
Copy link
Contributor

Summary

Fixing incorrect JetBrains Plugin rating values for [JetBrainsRating]

Fixes #7139 (see details within)

Testing Done

  • Tested locally with two known plugins (see below screenshots)
  • Ran npm run test:services -- --only=jetbrains; 100% pass (see below screenshots for coverage results)

Screenshots

Local deploy with two known JetBrains Plugins

With Ratings

Screen Shot 2021-10-13 at 02 45 57

Without Ratings

Screen Shot 2021-10-13 at 02 45 48

Coverage Results for JetBrains service (100% coverage for jetbrains-rating.service.js)

Screen Shot 2021-10-13 at 02 47 21

@shields-ci
Copy link

shields-ci commented Oct 13, 2021 •
edited

Messages
📖 ✨ Thanks for your contribution to Shields, @ChrisCarini!

Generated by 🚫 dangerJS against 39b17da

@shields-cd shields-cd temporarily deployed to shields-staging-pr-7140 October 13, 2021 19:39 Inactive
@chris48s chris48s mentioned this pull request Oct 13, 2021
Closed
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7140 October 13, 2021 20:39 Inactive
@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Oct 13, 2021
chris48s
chris48s approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down with this, but I'll leave it open till tomorrow just to give @calebcartwright a chance to chime in if needed.

@calebcartwright
Copy link
Member

Haven't actually looked at the changes, but I've no objections to moving ahead with this given the dialog with JB happening in parallel

@repo-ranger repo-ranger bot merged commit f04826a into badges:master Oct 15, 2021
@ChrisCarini ChrisCarini deleted the ChrisCarini/fixJetBrainsPluginRatings branch October 15, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect value shown for ratings [jetbrains]
5 participants
@ChrisCarini @shields-ci @calebcartwright @chris48s @shields-cd