Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thunderstore API call #9837

Closed
chris48s opened this issue Dec 22, 2023 · 3 comments · Fixed by #9886
Closed

Update thunderstore API call #9837

chris48s opened this issue Dec 22, 2023 · 3 comments · Fixed by #9886
Labels
service-badge Accepted and actionable changes, features, and bugs

Comments

@chris48s
Copy link
Member

📋 Description

Currently the thunderstore version badge relies on an "experimental" endpoint.

There's an upstream issue to get this into a stable /v1 endpoint: thunderstore-io/Thunderstore#970

Once this is done, update our code to use it.

/cc @Lordfirespeed
@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Dec 22, 2023
@chris48s chris48s mentioned this issue Dec 22, 2023
Merged
@chris48s
Copy link
Member Author

chris48s commented Jan 8, 2024

Looks like the upstream issue is now closed - thunderstore-io/Thunderstore#970

@Lordfirespeed - are you still happy to follow this one up?

@Lordfirespeed
Copy link
Contributor

Absolutely! I'm just waiting on the next Thunderstore deploy (I don't think their live API has been updated yet)

@Lordfirespeed
Copy link
Contributor

Here's a test URL:
https://thunderstore.io/api/v1/package-metrics/BepInEx/BepInExPack/

Lordfirespeed added a commit to Lordfirespeed/shields that referenced this issue Jan 9, 2024
@Lordfirespeed
replace experimental API usage with newly available v1 API
b598745 
resolves badges#9837
@Lordfirespeed Lordfirespeed mentioned this issue Jan 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2024
@Lordfirespeed
replace experimental API usage with newly available v1 API (#9886)
bfcbaea 
resolves #9837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[thunderstore] Replace experimental API usage with newly available v1 API Lordfirespeed/shields
2 participants
@chris48s @Lordfirespeed