Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace lgtm logo with improved one #1679

Merged
merged 1 commit into from
May 10, 2018
Merged

replace lgtm logo with improved one #1679

merged 1 commit into from
May 10, 2018

Conversation

s0
Copy link
Contributor

@s0 s0 commented May 8, 2018

Sorry for the trial+error and additional noise, I decided that I didn't like how the small lgtm logo looked, so I created an alternative that I've used in this PR. (among other things, I work on lgtm's branding)

Old:
cloudstack 1
2018-05-08-151045_5120x1440_scrot

New:
cloudstack
2018-05-08-150500_5120x1440_scrot

@shields-ci
Copy link

shields-ci commented May 8, 2018

Messages
📖

✨ Thanks for your contribution to Shields, @samlanning!

Generated by 🚫 dangerJS

Copy link
Member

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current This PR logoWidth
lgtm-current-logo-default lgtm-new-logo-default default
lgtm-current-logo-20 lgtm-new-logo-20 20

I personally prefer the current one, but both look good.
Thanks for the PR!

Copy link
Member

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just noticed it has some style & font information that's not needed in a few places, could you remove those please.

font-family="sans-serif" font-weight="400" overflow="visible" style="line-height:normal;font-variant-ligatures:normal;font-variant-position:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-feature-settings:normal;text-indent:0;text-align:start;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000;text-transform:none;text-orientation:mixed;shape-padding:0;isolation:auto;mix-blend-mode:normal" white-space="normal"

@s0
Copy link
Contributor Author

s0 commented May 10, 2018

Sorry about that, done =)

@RedSparr0w RedSparr0w merged commit f43096a into badges:master May 10, 2018
@RedSparr0w
Copy link
Member

Thanks, Looks good to me.
Merged! 😄

@chris48s chris48s mentioned this pull request Jan 5, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants