Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LGTM #1158

Merged
merged 1 commit into from
Jan 15, 2019
Merged

add LGTM #1158

merged 1 commit into from
Jan 15, 2019

Conversation

chris48s
Copy link
Contributor

@chris48s chris48s commented Jan 5, 2019

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This is another difficult one to source well. Usually the LGTM logo has more colours (most clearly seen here https://github.com/lgtmhq/ ). This is based on a version which was adapted by one of the LGTM devs: badges/shields#1679 - it reduces to 1 colour well. There are no formal brand guidelines.

alexa rank: https://www.alexa.com/siteinfo/lgtm.com

lgtm

@ericcornelissen
Copy link
Contributor

I'm a bit wary of adding LGTM right now, although promising and somewhat popular (i.e. Alexa rank of almost 500k) it seems to be a pretty new project (started in ~October of last year) if I look at the Alexa rank.

Do you have any other sources of the popularity and lifespan of the project?

@birjj
Copy link
Contributor

birjj commented Jan 11, 2019

@ericcornelissen I'm ok with adding it; the deprecated GitHub archive had ~1k stars, a respectable (although not massive) amount, and the Alexa rank has risen significantly in the last two months. Further, 502k is so close to our cut-off that it'd almost feel petty to decline based on that :P

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jan 15, 2019

@birjolaxew my problem is not with regards to popularity but with regards to the lifespan of the project. To be fair though I don't expect the service to be shut down anytime soon, also given there's a bigger company behind lgtm (Semmle).

I'm okay merging this if you are 👍

@birjj birjj merged commit 9bb9b7d into simple-icons:develop Jan 15, 2019
@davidklebanoff davidklebanoff added the new icon Issues or pull requests for adding a new icon label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants