Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deployment status using GitHub Actions #5709

Merged
merged 2 commits into from Oct 15, 2020

Conversation

platan
Copy link
Member

@platan platan commented Oct 15, 2020

2 years ago we created a bot that adds a comment the end of the PR with deployment status (#1708). The bot (https://github.com/apps/shields-deployment) was a https://github.com/bkeepers/workflow app running at ZEIT Now 1.0.

This year zeit.co announced Zeit Now 1.0 shutdown. On August 7, 2020, all Zeit Now 1.0 deployments were deleted.

Just before the shutdown, I moved Workflow instance to AWS Lambda. On the one hand it was a good move, because:

On the other hand, I have some problems with the Workflow/serverless-lambda, because they use incompatible versions of Probot and it required some hacks to make them work properly (the result is stored in my private repo).

In this PR I remove Probot's configuration and migrate the whole solution to GitHub Actions.

platan/shields-deployment-status-example#55 is an example PR using similar GitHub Action

Zrzut ekranu 2020-10-15 o 17 57 43

@shields-ci
Copy link

shields-ci commented Oct 15, 2020

Messages
📖 ✨ Thanks for your contribution to Shields, @platan!

Generated by 🚫 dangerJS against 737c766

@platan platan added the developer-experience Dev tooling, test framework, and CI label Oct 15, 2020
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Simplifying this seems like a good move 👍

@platan platan merged commit 1aa25ab into badges:master Oct 15, 2020
@calebcartwright
Copy link
Member

Indeed, well done! I like having it defined and being able to manage entirely within repo too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants