Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix regex to match [codecov]'s flags #6655

Merged
merged 3 commits into from
Jun 24, 2021
Merged

fix: fix regex to match [codecov]'s flags #6655

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61adcea
fix: fix regex to match codecov's flags
bubkoo Jun 23, 2021
787cc0d
refactor: remove unnecessary escape char in regex
bubkoo Jun 23, 2021
89c6f7d
refactor: fix prettier warnings
bubkoo Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions services/codecov/codecov.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ const legacySchema = Joi.object({
const queryParamSchema = Joi.object({
token: Joi.string(),
// https://docs.codecov.io/docs/flags
// Flags must be lowercase, alphanumeric, and not exceed 45 characters
flag: Joi.string().regex(/^[a-z0-9_]{1,45}$/),
// Flags Must consist only of alphanumeric characters, '_', '-', or '.'
// and not exceed 45 characters.
flag: Joi.string().regex(/^[\w.-]{1,45}$/),
}).required()

const schema = Joi.object({
Expand Down