Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return string instead of object from getDependencyVersion function; affects [githubpackagejson npmdependencyversion] #8396

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Return string instead of object from getDependencyVersion function; affects [githubpackagejson npmdependencyversion] #8396

merged 2 commits into from
Sep 13, 2022

Conversation

pr7prashant
Copy link
Contributor

Cleanup for #8373 (comment)

This function does currently return an object, but it doesn't really need to. I expect this is an artefact of some past refactoring. A nice cleanup we could do here would be to update this so it just returns a string and update the handful of places it is called accordingly.

@shields-ci
Copy link

shields-ci commented Sep 12, 2022 •
edited

Warnings
⚠️ This PR modified service code for npm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @pr7prashant!

Generated by 🚫 dangerJS against 8e2ecf1

@chris48s chris48s changed the title Return string instead of object from getDependencyVersion function Return string instead of object from getDependencyVersion function; affects [githubpackagejson npmdependencyversion] Sep 13, 2022
@chris48s chris48s added developer-experience Dev tooling, test framework, and CI squash when passing labels Sep 13, 2022
@chris48s
Copy link
Member

nice - thanks 👍

@repo-ranger repo-ranger bot merged commit e3c938b into badges:master Sep 13, 2022
@pr7prashant pr7prashant deleted the package-json-helper-cleanup branch September 14, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pr7prashant @shields-ci @chris48s