remove pull_request:edited trigger from most workflows #9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
going to merge this one and see if it helps as I bash through this week's dependabot PRs |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a lot of dependabot PRs to review, sometimes we use all our rate limit up and stuff starts failing.
I think one of the issues causing this is that because we trigger a build on
pull_request:edited, as soon as dependabot edits the top post of a PR to say "dependabot is rebasing this PR", all the builds unnecessarily re-trigger. Then they retrigger again onpull_request:synchronizewhen it force-pushes the branch.This PR removes the
pull_request:editedtrigger from most of the workflows. I've left it on the service tests because its quite useful that editing the PR title re-runs those.Hopefully this should reduce the number of builds we run a bit and make it a bit easier to stay under the rate limit.